Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to override template properties from command line #269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MontealegreLuis
Copy link
Contributor

  • Allow overriding template.url or template.directory from command line

For example

bin/couscous preview --config template.url=https://github.com/CouscousPHP/Template-Dark.git

As mentioned in this issue comment: #159 (comment)

Allow overriding template.url or template.directory from command line
@MontealegreLuis MontealegreLuis changed the title Add support to override template properties Add support to override template properties from command line Feb 15, 2024
@MontealegreLuis
Copy link
Contributor Author

MontealegreLuis commented Feb 15, 2024

Tests are passing locally, but not sure if there's anything else I need to check.

When I run my change locally

bin/couscous preview --config template.url=https://github.com/CouscousPHP/Template-Dark.git

I see this error

 There was an error while rendering the file "templates.html" with the layout "templates.twig": Template "templates.twig" is   
  not defined. 

Not sure if it's something specific with the documentation in the docs directory, or If should try to fix the error above.

Disregard this observation, I just noticed this file https://github.com/CouscousPHP/Couscous/blob/master/templates.md uses a different layout, and the templates I used to check don't have a layout named templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant