-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Replace Parsedown with CommonMark #134
base: master
Are you sure you want to change the base?
Conversation
hason
commented
Nov 16, 2015
- Add support for a new Converter base class for CommonMark mnapoli/FrontYAML#10
- tests
Thank you for the PR. Have also a look at #69 (comment) I did try to migrate to CommonMark, but it doesn't support Markdown Extra. I'm afraid it might be blocking if we want to avoid breaking BC (and green tests). |
I am just screening through the couscous-repository. Why would we want to change the markdown-parser? I see that parsedown can handle extensions (https://github.com/erusev/parsedown/wiki/Tutorial:-Create-Extensions) so we could add ours if we want to expand it... |
CommonMark parses the text into some sort of AST (abstract syntax tree), i.e. a model of the whole document. That means we can much more easily manipulate it. For example it would be very easy to extract titles to create a summary. |
Okay, thanks for the update. I'll look at CommonMark instead of Parsedown ;) |
FYI it does support GFM now, and has a bunch of other useful extensions that might be helpful: https://commonmark.thephpleague.com/1.4/extensions/overview/#included-extensions |
@colinodell thanks for the update, love your work. I'd love to switch to CommonMark, I haven't much time to spend on the migration for now but I'll definitely keep that in my todo list. |