Merge pull request #713 from coursemology-collab/allen/100-coverage

100% coverage

app/controllers/course/assessment/programming_evaluations_controller.rb

@@ -14,10 +14,6 @@ class Course::Assessment::ProgrammingEvaluationsController < ApplicationControll
   authorize_resource :programming_evaluation, class: Course::Assessment::ProgrammingEvaluation.name,
                                               except: [:allocate, :package]
 
-  def index
-    @programming_evaluations = @programming_evaluations.with_language(language_param)
-  end
-
   def allocate
     save_success = @programming_evaluations.
                    each { |evaluation| evaluation.assign!(current_user) }.

spec/controllers/user/omniauth_callbacks_controller_spec.rb

@@ -48,6 +48,18 @@
           expect(flash[:danger]).to eq(I18n.t('user.omniauth_callbacks.facebook.sign_in_failure'))
         end
       end
+
+      context 'when the user is signed in' do
+        let(:user) { create(:user) }
+        before { sign_in(user) }
+
+        it 'shows an error message when omniauth data is incomplete' do
+          facebook_data.uid = nil
+
+          subject
+          expect(flash[:danger]).to eq(I18n.t('user.omniauth_callbacks.facebook.failed'))
+        end
+      end
     end
   end
 end