Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check and clean nodes which were created by the server, but client is not aware of it #3

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ishveda
Copy link

@ishveda ishveda commented Apr 7, 2020

If the node potentially was created by the server, but then client returned an error (e.g. ErrConnectionClose because of networking glitch), the node remains bound to the restored session and prevents acquisition of newer locks, since according to zk recipes for locks, there is a watch created on that node within the following lock, which dead locks further lock acquisition.

ishveda added 4 commits April 7, 2020 20:59
…9_lock_deadlock"

This reverts commit 6916e6f, reversing
changes made to 2cc03de.

Revert saving attemptedLockPath, since session reconnect zk-node (lock) is eventually removed, but attemptedLockPath is not cleared, given that it incorrectly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants