[Upgrade] Go1.18 to 1.21 version upgrade #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.17.0. - [Commits](golang/crypto@v0.14.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
just update go version 1.21 and depandency update except github.com/docker/docker v20.10.18+incompatible because docker part used struct dockerV20Exec -> only docker v20 Signed-off-by: HyoBin Kim <[email protected]>
ioutil -> io error message first character uppercase used -> lowercase struct oidcDiscoverImpl felid httpClient unused -> commenting go.containerssh.io/libcontainerssh/internal/ssh double import -> remove Signed-off-by: HyoBin Kim <[email protected]>
workflow go version 1.18 -> 1.21 Signed-off-by: okestro-hbkim <[email protected]>
departed func math/rand -> crypto/rand k.exec.Stream(option) -> k.exec.StreamWithContext(ctx, option) Signed-off-by: HyoBin Kim <[email protected]>
ioutil -> io Signed-off-by: okestro-hbkim <[email protected]>
go action pipeline goversion upgrade 1.18 -> 1.21 Signed-off-by: okestro-hbkim <[email protected]>
no use codecov (CODECOV_TOKEN empty) Signed-off-by: HyoBin Kim <[email protected]>
action update test Signed-off-by: HyoBin Kim <[email protected]>
test fail Signed-off-by: HyoBin Kim <[email protected]>
test fail Signed-off-by: HyoBin Kim <[email protected]>
codecov-action reactivate Signed-off-by: okestro-hbkim <[email protected]>
Kim-Hyo-Bin
changed the title
|
LGTM! Thanks! Looks like there are some conflicts though, mind resolving them? |
Signed-off-by: okestro-hbkim <[email protected]>
in my case (ubuntu 22.04 - amd64), There is no conflict. tell me about the conflict. please check test in your enviroment before approve. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #566 +/- ##
=======================================
Coverage ? 37.33%
=======================================
Files ? 196
Lines ? 17196
Branches ? 0
=======================================
Hits ? 6420
Misses ? 10186
Partials ? 590 ☔ View full report in Codecov by Sentry. |
tsipinakis
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#564
go lang version up 1.18 -> 1.21
some package depandency upgrade
dockerV20Exec structure exists, docker/docker(moby/moby) is skiped from the update.
(latest 25.X.X)
github action update and passed
By contributing to this repository, I agree to the contribution guidelines.