Ldap permissions support #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Took 5 hours 16 minutes
Took 1 hour 39 minutes
|
This looks great @vixns . I created a branch of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support of "LDAP permissions", aka "permissions stored in the ldap group entries".
The group membership and permissions are updated at a configurable interval, restarting marathon after a group or permission change is no longer required. (#13)
A few commits are from the @minyk fork, because I first based my fork on it. These commits are not strictly required, but seems good to me. I can rebase on the original master branch if marathon 1.4 support is still required.