-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaned en.json with checking scripts #331
Open
yuanwang04
wants to merge
15
commits into
ContactAssistApp:master
Choose a base branch
from
yuanwang04:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheng-tan
requested changes
Aug 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we only have three test cases in this file and break down this PR:
- There is no unused keys (only check the en.json file, make sure all the keys is used in the app)
- There is no missing keys (all the keys used in the app are having values in en.json)
- Every language has same keys (Load in all translations file and check if their keys are the same)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #328
Wrote scripts to check for missing keys and extra keys in en.json and es.json. It will automatically remove extra keys.
For this script to work, keys in en.json and es.json should only include [a-zA-Z0-9-_]. Especially it should NOT include '.'
The script is based on jest. To run, use
npm run test
.A cleaned version of en.json/es.json will be created in
locales/newEn.json
andlocales/newEs.json
The following keys seem to be missing in es.json:
[
"missing_locations.title",
"missing_locations.description",
"missing_locations.import_button",
"disclaimer.title",
"disclaimer.content",
"location.unknown",
"data_storage_modal.title",
"data_storage_modal.desc_1",
"data_storage_modal.desc_2",
"data_storage_modal.delete_success",
"data_storage_modal.delete_failure",
"data_storage_modal.delete_button",
"export.message",
"export.title",
"export.description"
]