Ensure all trace files get deleted

Previously trace files were never deleted for failing runs. This, unfortunately, means a very slow build up of disk space being consumed when a reasonable number of tests fail.
Consensys · Dec 17, 2024 · 8aec657 · 8aec657
1 parent 09709db
commit 8aec657
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/reference-tests/src/test/java/net/consensys/linea/BlockchainReferenceTestTools.java b/reference-tests/src/test/java/net/consensys/linea/BlockchainReferenceTestTools.java
@@ -115,6 +115,9 @@ public class BlockchainReferenceTestTools {
     PARAMS.ignore("Call50000");
     PARAMS.ignore("static_LoopCallsDepthThenRevert3");
     PARAMS.ignore("Return50000");
+    // DJP: Also seem to consume lots of memory
+    PARAMS.ignore("static_LoopCallsThenRevert");    
+    PARAMS.ignore("randomStatetest185");
 
     // Absurd amount of gas, doesn't run in parallel.
     PARAMS.ignore("randomStatetest94_\\w+");

diff --git a/testing/src/main/java/net/consensys/linea/testing/ExecutionEnvironment.java b/testing/src/main/java/net/consensys/linea/testing/ExecutionEnvironment.java
@@ -75,7 +75,7 @@ public static void checkTracer(
     } catch (IOException e) {
       throw new RuntimeException(e);
     } finally {
-      if (traceFilePath != null && traceValidated) {
+      if (traceFilePath != null) {
         if (System.getenv("PRESERVE_TRACE_FILES") == null) {
           boolean traceFileDeleted = traceFilePath.toFile().delete();
           final Path finalTraceFilePath = traceFilePath;