fix: enable previously disabled tests (#1552)

* Enable previously disabled tests This enables a number of previously disabled tests which actually pass. This also tidies up the naming of some of the regular tests. * Disable tests which still use too much resource This disable remaining tests which actually still use too much resource for `go-corset`. Potentially, we should be considering some kind of graceful exit when this happens.
Consensys · Dec 5, 2024 · 0a9f031 · 0a9f031
1 parent fc63c9d
commit 0a9f031
Show file tree

Hide file tree

Showing 8 changed files with 30 additions and 40 deletions.
diff --git a/.github/workflows/gradle-ethereum-tests.yml b/.github/workflows/gradle-ethereum-tests.yml
@@ -1,4 +1,4 @@
-name: reference tests
+name: Daily State Tests
 
 on:
   schedule:
@@ -58,7 +58,7 @@ jobs:
           webhook: ${{ secrets.SLACK_WEBHOOK_URL }}
           webhook-type: webhook-trigger
           payload: |
-             name: "Daily Reference Tests (Rust Corset)"
+             name: "Daily State Tests (Rust Corset)"
              status: "${{ job.status }}"
 
   ethereum-tests-go-corset:
@@ -110,5 +110,5 @@ jobs:
           webhook: ${{ secrets.SLACK_WEBHOOK_URL }}
           webhook-type: webhook-trigger
           payload: |
-             name: "Daily Reference Tests (Go Corset)"
+             name: "Daily State (Go Corset)"
              status: "${{ job.status }}"
diff --git a/.github/workflows/reference-blockchain-tests.yml b/.github/workflows/reference-blockchain-tests.yml
@@ -1,4 +1,4 @@
-name: Daily Reference Blockchain Tests
+name: Daily Blockchain Tests
 
 on:
   schedule:
@@ -96,5 +96,5 @@ jobs:
           webhook: ${{ secrets.SLACK_WEBHOOK_URL }}
           webhook-type: webhook-trigger
           payload: |
-             name: "Daily Reference Tests"
+             name: "Daily Blockchain"
              status: "${{ job.status }}"
diff --git a/arithmetization/src/test/java/net/consensys/linea/replaytests/Issue1031Tests.java b/arithmetization/src/test/java/net/consensys/linea/replaytests/Issue1031Tests.java
@@ -23,7 +23,6 @@
 @Tag("replay")
 public class Issue1031Tests {
 
-  // @Disabled
   @Test
   void issue_1090_range_10_20() {
     replay(LINEA_MAINNET, "10-20.mainnet.json.gz");

diff --git a/arithmetization/src/test/java/net/consensys/linea/replaytests/Issue1116Tests.java b/arithmetization/src/test/java/net/consensys/linea/replaytests/Issue1116Tests.java
@@ -24,7 +24,6 @@
 @Tag("replay")
 public class Issue1116Tests {
 
-  // @Disabled
   @Test
   void issue_1116_block_8019521() {
     replay(LINEA_MAINNET, "8019521.mainnet.json.gz");

diff --git a/arithmetization/src/test/java/net/consensys/linea/replaytests/Issue1126Tests.java b/arithmetization/src/test/java/net/consensys/linea/replaytests/Issue1126Tests.java
@@ -17,7 +17,6 @@
 import static net.consensys.linea.replaytests.ReplayTestTools.replay;
 import static net.consensys.linea.testing.ReplayExecutionEnvironment.LINEA_MAINNET;
 
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Tag;
 import org.junit.jupiter.api.Test;
 
@@ -63,97 +62,81 @@ void test_4477086_4477226() {
     replay(LINEA_MAINNET, "4477086-4477226.mainnet.json.gz");
   }
 
-  @Disabled
   @Test
   void test_3290673_3290679() {
     replay(LINEA_MAINNET, "3290673-3290679.mainnet.json.gz");
   }
 
-  @Disabled
   @Test
   void test_3290746_3290752() {
     replay(LINEA_MAINNET, "3290746-3290752.mainnet.json.gz");
   }
 
-  @Disabled
   @Test
   void test_3315684_3315690() {
     replay(LINEA_MAINNET, "3315684-3315690.mainnet.json.gz");
   }
 
-  @Disabled
   @Test
   void test_3374278_3374284() {
     replay(LINEA_MAINNET, "3374278-3374284.mainnet.json.gz");
   }
 
-  @Disabled
   @Test
   void test_3385404_3385411() {
     replay(LINEA_MAINNET, "3385404-3385411.mainnet.json.gz");
   }
 
-  @Disabled
   @Test
   void test_3410170_3410240() {
     replay(LINEA_MAINNET, "3410170-3410240.mainnet.json.gz");
   }
 
-  @Disabled
   @Test
   void test_3423488_3423521() {
     replay(LINEA_MAINNET, "3423488-3423521.mainnet.json.gz");
   }
 
-  @Disabled
   @Test
   void test_3424829_3424864() {
     replay(LINEA_MAINNET, "3424829-3424864.mainnet.json.gz");
   }
 
-  @Disabled
   @Test
   void test_3429701_3429735() {
     replay(LINEA_MAINNET, "3429701-3429735.mainnet.json.gz");
   }
 
-  @Disabled
   @Test
   void test_3431193_3431232() {
     replay(LINEA_MAINNET, "3431193-3431232.mainnet.json.gz");
   }
 
-  @Disabled
   @Test
   void test_3431567_3431601() {
     replay(LINEA_MAINNET, "3431567-3431601.mainnet.json.gz");
   }
 
-  @Disabled
   @Test
   void test_4323962_4324012() {
     replay(LINEA_MAINNET, "4323962-4324012.mainnet.json.gz");
   }
 
-  @Disabled
   @Test
   void test_4343434_4343473() {
     replay(LINEA_MAINNET, "4343434-4343473.mainnet.json.gz");
   }
 
-  @Disabled
   @Test
   void test_4519246_4519309() {
     replay(LINEA_MAINNET, "4519246-4519309.mainnet.json.gz");
   }
 
-  @Disabled
   @Test
   void test_4556007_4556115() {
     replay(LINEA_MAINNET, "4556007-4556115.mainnet.json.gz");
   }
 
-  @Disabled
   @Test
   void test_4583379_4583463() {
     replay(LINEA_MAINNET, "4583379-4583463.mainnet.json.gz");

diff --git a/arithmetization/src/test/java/net/consensys/linea/replaytests/Issue1216Tests.java b/arithmetization/src/test/java/net/consensys/linea/replaytests/Issue1216Tests.java
@@ -20,7 +20,6 @@
 import net.consensys.linea.zktracer.module.hub.AccountSnapshot;
 import net.consensys.linea.zktracer.module.hub.Hub;
 import org.hyperledger.besu.datatypes.Address;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Tag;
 import org.junit.jupiter.api.Test;
 
@@ -42,7 +41,6 @@ public class Issue1216Tests {
    * blowing up with a NPE since the "after" version of the self destructor didn't exist yet in the
    * code. This was solved in issue #1216.
    */
-  @Disabled
   @Tag("nightly")
   @Tag("replay")
   @Test

diff --git a/arithmetization/src/test/java/net/consensys/linea/replaytests/LeosNewRanges.java b/arithmetization/src/test/java/net/consensys/linea/replaytests/LeosNewRanges.java
@@ -18,115 +18,138 @@
 import static net.consensys.linea.testing.ReplayExecutionEnvironment.LINEA_MAINNET;
 
 import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Tag;
 import org.junit.jupiter.api.Test;
 
-@Disabled
+@Tag("nightly")
 public class LeosNewRanges {
+  @Disabled
   @Test
   void leos_new_ranges_2258472_2258607() {
     replay(LINEA_MAINNET, "2258472-2258607.mainnet.json.gz");
   }
 
+  @Disabled
   @Test
   void leos_new_ranges_2291967_2292180() {
     replay(LINEA_MAINNET, "2291967-2292180.mainnet.json.gz");
   }
 
+  @Disabled
   @Test
   void leos_new_ranges_2321460_2321556() {
     replay(LINEA_MAINNET, "2321460-2321556.mainnet.json.gz");
   }
 
+  @Disabled
   @Test
   void leos_new_ranges_2359782_2359913() {
     replay(LINEA_MAINNET, "2359782-2359913.mainnet.json.gz");
   }
 
+  @Disabled
   @Test
   void leos_new_ranges_2362189_2362291() {
     replay(LINEA_MAINNET, "2362189-2362291.mainnet.json.gz");
   }
 
+  @Disabled("Out-Of-Memory")
   @Test
   void leos_new_ranges_5002125_5002158() {
     replay(LINEA_MAINNET, "5002125-5002158.mainnet.json.gz");
   }
 
+  @Disabled
   @Test
   void leos_new_ranges_5004016_5004055() {
     replay(LINEA_MAINNET, "5004016-5004055.mainnet.json.gz");
   }
 
+  @Disabled
   @Test
   void leos_new_ranges_5004767_5004806() {
     replay(LINEA_MAINNET, "5004767-5004806.mainnet.json.gz");
   }
 
+  @Disabled
   @Test
   void leos_new_ranges_5006057_5006092() {
     replay(LINEA_MAINNET, "5006057-5006092.mainnet.json.gz");
   }
 
+  @Disabled
   @Test
   void leos_new_ranges_5006988_5007039() {
     replay(LINEA_MAINNET, "5006988-5007039.mainnet.json.gz");
   }
 
+  @Disabled("Out-Of-Memory")
   @Test
   void leos_new_ranges_5012236_5012275() {
     replay(LINEA_MAINNET, "5012236-5012275.mainnet.json.gz");
   }
 
+  @Disabled
   @Test
   void leos_new_ranges_5025817_5025859() {
     replay(LINEA_MAINNET, "5025817-5025859.mainnet.json.gz");
   }
 
+  @Disabled("Out-Of-Memory")
   @Test
   void leos_new_ranges_5037583_5037608() {
     replay(LINEA_MAINNET, "5037583-5037608.mainnet.json.gz");
   }
 
+  @Disabled
   @Test
   void leos_new_ranges_5042942_5042990() {
     replay(LINEA_MAINNET, "5042942-5042990.mainnet.json.gz");
   }
 
+  @Disabled("Out-Of-Memory")
   @Test
   void leos_new_ranges_5043442_5043497() {
     replay(LINEA_MAINNET, "5043442-5043497.mainnet.json.gz");
   }
 
+  @Disabled
   @Test
   void leos_new_ranges_5043997_5044049() {
     replay(LINEA_MAINNET, "5043997-5044049.mainnet.json.gz");
   }
 
+  @Disabled
   @Test
   void leos_new_ranges_5044557_5044619() {
     replay(LINEA_MAINNET, "5044557-5044619.mainnet.json.gz");
   }
 
+  @Disabled
   @Test
   void leos_new_ranges_5045161_5045232() {
     replay(LINEA_MAINNET, "5045161-5045232.mainnet.json.gz");
   }
 
+  @Disabled
   @Test
   void leos_new_ranges_5046373_5046435() {
     replay(LINEA_MAINNET, "5046373-5046435.mainnet.json.gz");
   }
 
+  @Disabled
   @Test
   void leos_new_ranges_5046997_5047058() {
     replay(LINEA_MAINNET, "5046997-5047058.mainnet.json.gz");
   }
 
+  @Disabled
   @Test
   void leos_new_ranges_5050036_5050130() {
     replay(LINEA_MAINNET, "5050036-5050130.mainnet.json.gz");
   }
 
+  @Disabled("Out-Of-Memory")
   @Test
   void leos_new_ranges_5057558_5057616() {
     replay(LINEA_MAINNET, "5057558-5057616.mainnet.json.gz");

diff --git a/arithmetization/src/test/java/net/consensys/linea/replaytests/ReplayTests.java b/arithmetization/src/test/java/net/consensys/linea/replaytests/ReplayTests.java
@@ -51,50 +51,42 @@ void bulkReplay() {
     // bulkReplay(LINEA_MAINNET, "");
   }
 
-  // @Disabled
   @Test
   void failingMmuModexp() {
     replay(LINEA_MAINNET, "5995162.mainnet.json.gz");
   }
 
-  // @Disabled
   @Test
   void failRlpAddress() {
     replay(LINEA_MAINNET, "5995097.mainnet.json.gz");
   }
 
-  // @Disabled
   @Test
   void rlprcptManyTopicsWoLogData() {
     replay(LINEA_MAINNET, "6569423.mainnet.json.gz");
   }
 
-  // @Disabled
   @Test
   void multipleFailingCallToEcrecover() {
     replay(LINEA_MAINNET, "5000544.mainnet.json.gz");
   }
 
-  // @Disabled
   @Test
   @Tag("nightly")
   void incident777zkGethMainnet() {
     replay(LINEA_MAINNET, "7461019-7461030.mainnet.json.gz");
   }
 
-  // @Disabled
   @Test
   void issue1006() {
     replay(LINEA_MAINNET, "6032696-6032699.mainnet.json.gz");
   }
 
-  // @Disabled
   @Test
   void issue1004() {
     replay(LINEA_MAINNET, "6020023-6020029.mainnet.json.gz");
   }
 
-  // @Disabled
   @Test
   void block_6110045() {
     // The purpose of this test is to check the mechanism for spotting divergence between the replay
@@ -103,19 +95,16 @@ void block_6110045() {
     replay(LINEA_MAINNET, "6110045.mainnet.json.gz");
   }
 
-  // @Disabled
   @Test
   void failingCreate2() {
     replay(LINEA_MAINNET, "2250197.mainnet.json.gz");
   }
 
-  // @Disabled
   @Test
   void blockHash1() {
     replay(LINEA_MAINNET, "8718090.mainnet.json.gz");
   }
 
-  // @Disabled
   @Test
   void blockHash2() {
     replay(LINEA_MAINNET, "8718330.mainnet.json.gz");
@@ -139,10 +128,9 @@ void failedCreate2() {
     replay(LINEA_MAINNET, "41640-41649.mainnet.json.gz");
   }
 
-  @Disabled() // Unknown Problem
   @Test
   void largeInitCode() {
-    replay(LINEA_SEPOLIA, "3318494.sepolia.mainnet.json.gz");
+    replay(LINEA_SEPOLIA, "3318494.sepolia.json.gz");
   }
 
   /**