Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Module Line Count Verification to linea_estimateGas RPC Method #1

Merged
merged 11 commits into from
Apr 10, 2024

Conversation

Gabriel-Trintinalia
Copy link
Collaborator

@Gabriel-Trintinalia Gabriel-Trintinalia commented Apr 8, 2024

Main Changes:

  • Module limit validation logic has been extracted from its previous location and encapsulated within a new class, ModuleLineCountValidator. This change allows for the reuse of module validation logic across different parts of the plugin
  • The moduleLimitFilePath configuration has been moved out of the transaction selection configuration and into its own dedicated tracer configuration.
  • The linea_estimateGas RPC method has been changed to include module limit validation.
  • A new TracerAggregator class has been implemented to delegate tracing methods to multiple tracers.

Pending:

  • Implement tests
  • Fix zkTracer Validation on arithmetization repo

@Gabriel-Trintinalia Gabriel-Trintinalia changed the title Feat/issue 918/estimate gas limit module Extend Module Line Count Verification to linea_estimateGas RPC Method Apr 9, 2024
@Gabriel-Trintinalia Gabriel-Trintinalia force-pushed the feat/issue-918/estimate-gas-limit-module branch from 45fa4eb to 83396d4 Compare April 9, 2024 13:28
Signed-off-by: Gabriel-Trintinalia <[email protected]>
Signed-off-by: Gabriel-Trintinalia <[email protected]>
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia Gabriel-Trintinalia self-assigned this Apr 9, 2024
@Gabriel-Trintinalia Gabriel-Trintinalia marked this pull request as ready for review April 9, 2024 16:36
Copy link
Contributor

@fab-10 fab-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of minor things

@Gabriel-Trintinalia Gabriel-Trintinalia merged commit 0be75a3 into main Apr 10, 2024
7 checks passed
@fab-10 fab-10 deleted the feat/issue-918/estimate-gas-limit-module branch June 26, 2024 14:16
@fab-10 fab-10 restored the feat/issue-918/estimate-gas-limit-module branch June 26, 2024 14:16
@fab-10 fab-10 deleted the feat/issue-918/estimate-gas-limit-module branch August 1, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants