[Chore] - standardise contract deploy logs #460
+252
−181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
============================================
- Coverage 68.18% 68.12% -0.07%
Complexity 1125 1125
============================================
Files 319 319
Lines 12789 12789
Branches 1275 1275
============================================
- Hits 8720 8712 -8
- Misses 3541 3548 +7
- Partials 528 529 +1
|
kyzooghost
reviewed
Dec 18, 2024
| return contract.waitForDeployment(); | ||
|
|
||
| const chainId = (await wallet.provider!.getNetwork()).chainId; | ||
| const txReceipt = await contract.deploymentTransaction()!.wait(); |
There was a problem hiding this comment.
Suggested change
| const txReceipt = await contract.deploymentTransaction()!.wait(); | |
| const txReceipt = await contract.deploymentTransaction()?.wait(); |
If contract.deploymentTransaction() = null then:
- ! => Will throw immediately with NodeJS runtime error
- ? => We will catch this in L28-30
There was a problem hiding this comment.
? syntax is used in other instances in this PR as well
| @@ -23,8 +23,8 @@ class MakefileContractDeploymentHelperKtTest { | |||
| assertThat( | |||
| getDeployedAddress( | |||
| listOf( | |||
| "L2MessageServiceV1.2.3 artifact has been deployed in 1.2659626659999998s ", | |||
| "L2MessageServiceV1.2.3 deployed: address=0xFE48d65B84AA0E23594Fd585c11cAD831F90AcB6 blockNumber=8", | |||
| "contract=L2MessageServiceV1.2.3 artifact has been deployed in 1.2659626659999998s ", | |||
There was a problem hiding this comment.
I think we haven't updated the TS code producing this log in contracts/scripts/hardhat/utils.ts - I see this pattern of log in deployUpgradableFromFactory and deployUpgradableWithAbiAndByteCode functions
So should we also update the console.log statements produced there? And if so, should we also update the other ... artifact has been deployed in ... statements in this file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements issue(s) #
Checklist