Finalized Updater - log the block number when it is skipped #459
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
jpnovais
approved these changes
Dec 17, 2024
jpnovais
reviewed
Dec 17, 2024
| @@ -46,7 +46,7 @@ class LineaBesuEngineBlockTagUpdater(private val blockchainService: BlockchainSe | |||
| throw e | |||
| } | |||
| } else { | |||
| log.warn("Linea safe/finalized block update: Skipped as getBlockByNumber returns empty result") | |||
| log.warn("Linea safe/finalized block update: Skipped as getBlockByNumber for block=$finalizedBlockNumber returns empty result") | |||
There was a problem hiding this comment.
Suggested change
| log.warn("Linea safe/finalized block update: Skipped as getBlockByNumber for block=$finalizedBlockNumber returns empty result") | |
| log.warn("Linea safe/finalized block update: Skipped as getBlockByNumber for block={} returns empty result", finalizedBlockNumber) |
we tend to favour argument placeholders over string interpolation as they tend to be more efficient. Although not that releval in this particular case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sally MacFarlane [email protected]This PR implements issue(s) #
Checklist