Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #451

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bridge-ui/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ docker run -p 3000:3000 linea/bridge-ui

Frontend should be available at: http://localhost:3000

### End to end tests
### End-to-end tests

E2E tests are run in the CI but can also be run locally.
Make sure `E2E_TEST_PRIVATE_KEY` .env (The private key used needs to have some sepolia ETH, USDC and WETH to run the tests)
Expand Down
10 changes: 5 additions & 5 deletions contracts/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ If the stack is *already running*, to redeploy the contracts, the following comm

Note: The addresses change per deployment due to nonce increments, so be sure to validate the correct ones are being used.

**NB:** The end to end tests run against a fresh stack and deploy with predetermined addresses.
**NB:** The end-to-end tests run against a fresh stack and deploy with predetermined addresses.

If there is a need to get predetermined addresses for contract deployments, the following script can be used [precomputeDeployedAddresses.ts](./scripts/operational/precomputeDeployedAddress.ts).

Expand All @@ -112,7 +112,7 @@ The L2MessageService deploy uses nonce 2 as the following are deployed beforehan
**Deploying the L1 contracts**
```
# This will deploy the Linea Rollup that is currently deployed on Mainnet - the current version is the LineaRollupV5.
# Some end to end tests will test future upgrades to validate the stack remains functional.
# Some end-to-end tests will test future upgrades to validate the stack remains functional.

# Note: By default a test/placeholder verifier contract is used `IntegrationTestTrueVerifier` if you wish to use a proper verifier, adjust the
# PLONKVERIFIER_NAME=IntegrationTestTrueVerifier in the make command to be something like PLONKVERIFIER_NAME=PlonkVerifierForDataAggregation .
Expand All @@ -131,7 +131,7 @@ make deploy-token-bridge-l1
**Deploying the L2 contracts**
```
# This will deploy the current L2 Message Service.
# Some end to end tests will test future upgrades to validate the stack remains functional.
# Some end-to-end tests will test future upgrades to validate the stack remains functional.

make deploy-l2messageservice

Expand All @@ -152,7 +152,7 @@ The above command will trigger the following commands to deploy:
- deploy-token-bridge-l2
- deploy-l2-test-erc20

Note: the deploy-l1-test-erc20 and deploy-l2-test-erc20 commands are executed for use in the end to end tests.
Note: the deploy-l1-test-erc20 and deploy-l2-test-erc20 commands are executed for use in the end-to-end tests.

## Installation and testing

Expand All @@ -167,4 +167,4 @@ pnpm run test
pnpm run test:reportgas

pnpm run coverage
```
```