Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prover: fix full prover over Sepolia issues #448

Merged
merged 12 commits into from
Dec 18, 2024

Conversation

AlexandreBelling
Copy link
Contributor

This fixes 2 issues:

  • Assignment of the functional public inputs
  • Constraints for the rolling-hash update
  • Constraints in the pi-interconnection over the rollingHash as well

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@AlexandreBelling AlexandreBelling added bug Something isn't working Prover Tag to use for all work impacting the prover labels Dec 13, 2024
@AlexandreBelling AlexandreBelling self-assigned this Dec 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.38%. Comparing base (a4dbf57) to head (30bfcc7).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #448      +/-   ##
============================================
+ Coverage     68.11%   70.38%   +2.27%     
+ Complexity     1125     1061      -64     
============================================
  Files           319      305      -14     
  Lines         12789    12201     -588     
  Branches       1275     1166     -109     
============================================
- Hits           8711     8588     -123     
+ Misses         3548     3141     -407     
+ Partials        530      472      -58     
Flag Coverage Δ *Carryforward flag
hardhat 98.70% <ø> (ø)
kotlin 68.06% <ø> (+2.33%) ⬆️ Carriedforward from d0d6145

*This pull request uses carry forward flags. Click here to find out more.

see 51 files with indirect coverage changes

@Tabaie Tabaie had a problem deploying to docker-build-and-e2e December 16, 2024 17:22 — with GitHub Actions Error
@Tabaie Tabaie temporarily deployed to docker-build-and-e2e December 18, 2024 19:11 — with GitHub Actions Inactive
@AlexandreBelling AlexandreBelling merged commit 7a67a21 into main Dec 18, 2024
25 checks passed
@AlexandreBelling AlexandreBelling deleted the prover/fix-full-prover branch December 18, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Prover Tag to use for all work impacting the prover
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants