-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prover: fix full prover over Sepolia issues #448
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandreBelling
added
bug
Something isn't working
Prover
Tag to use for all work impacting the prover
labels
Dec 13, 2024
AlexandreBelling
had a problem deploying
to
docker-build-and-e2e
December 13, 2024 23:46 — with
GitHub Actions
Error
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #448 +/- ##
============================================
+ Coverage 68.11% 70.38% +2.27%
+ Complexity 1125 1061 -64
============================================
Files 319 305 -14
Lines 12789 12201 -588
Branches 1275 1166 -109
============================================
- Hits 8711 8588 -123
+ Misses 3548 3141 -407
+ Partials 530 472 -58
*This pull request uses carry forward flags. Click here to find out more. |
Just to be sure, the one we have on main is the one we have on sepolia
AlexandreBelling
force-pushed
the
prover/fix-full-prover
branch
from
December 14, 2024 07:49
8b89f7a
to
40da052
Compare
AlexandreBelling
had a problem deploying
to
docker-build-and-e2e
December 14, 2024 07:52 — with
GitHub Actions
Error
Tabaie
had a problem deploying
to
docker-build-and-e2e
December 16, 2024 17:22 — with
GitHub Actions
Error
AlexandreBelling
had a problem deploying
to
docker-build-and-e2e
December 18, 2024 14:16 — with
GitHub Actions
Error
…onorepo into prover/fix-full-prover
AlexandreBelling
temporarily deployed
to
docker-build-and-e2e
December 18, 2024 14:24 — with
GitHub Actions
Inactive
bogdanbear
approved these changes
Dec 18, 2024
Tabaie
temporarily deployed
to
docker-build-and-e2e
December 18, 2024 19:11 — with
GitHub Actions
Inactive
Tabaie
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 2 issues:
Checklist