feat: added async retryer for currentL2BlockNumber in case the contra… #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonesho
temporarily deployed
to
docker-build-and-e2e
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
============================================
- Coverage 70.17% 70.14% -0.04%
Complexity 1070 1070
============================================
Files 306 306
Lines 12337 12330 -7
Branches 1179 1181 +2
============================================
- Hits 8658 8649 -9
- Misses 3200 3201 +1
- Partials 479 480 +1
*This pull request uses carry forward flags. Click here to find out more.
|
jonesho
commented
Dec 12, 2024
| backoffDelay = pollingInterval | ||
| ) { | ||
| SafeFuture.of(lineaRollupSmartContractWeb3jClient.currentL2BlockNumber().sendAsync()) | ||
| } |
There was a problem hiding this comment.
Add retry here to wait until currentL2BlockNumber on L1 is present, otherwise will get the following error:
time=2024-12-12T06:25:21,230Z level=FATAL message=org.web3j.tx.exceptions.ContractCallException: Empty value (0x) returned from contract | logger=CoordinatorAppCli thread=main | java.util.concurrent.ExecutionException: org.web3j.tx.exceptions.ContractCallException: Empty value (0x) returned from contract
2024-12-12 14:25:21 at java.base/java.util.concurrent.CompletableFuture.reportGet(Unknown Source)
2024-12-12 14:25:21 at java.base/java.util.concurrent.CompletableFuture.get(Unknown Source)
2024-12-12 14:25:21 at net.consensys.zkevm.coordinator.app.L1DependentApp.<init>(L1DependentApp.kt:308)
...
jonesho
commented
Dec 12, 2024
| vertx, | ||
| backoffDelay = config.pollingInterval | ||
| ) { | ||
| SafeFuture.of(lineaRollup.currentL2BlockNumber().sendAsync()) |
There was a problem hiding this comment.
Add retry here to wait until currentL2BlockNumber on L1 is present to avoid printing the "Empty value (0x) returned from contract" warning log message.
jonesho
commented
Dec 12, 2024
| @@ -31,7 +31,7 @@ class FeeHistoryFetcherImpl( | |||
| } | |||
|
|
|||
| private var cacheIsValidForBlockNumber: BigInteger = BigInteger.ZERO | |||
| private var feesCache: FeeHistory = getRecentFees().get() | |||
| private lateinit var feesCache: FeeHistory | |||
There was a problem hiding this comment.
To avoid calling getRecentFees().get() immediately on coordinator start-up (i.e. when L1 current ethBlockNumber is zero) which would lead to get(...) must not be null NPE
jonesho
temporarily deployed
to
docker-build-and-e2e
GitHub Actions
Inactive
…ct variable is not initialized yet
jonesho
force-pushed
the
317-improve-handling-of-errors-in-coordinator
branch
from
45da1fe to
93af0f5
Compare
jonesho
temporarily deployed
to
docker-build-and-e2e
GitHub Actions
Inactive
jonesho
temporarily deployed
to
docker-build-and-e2e
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ct variable is not initialized yet
This PR implements issue(s) #317
Checklist