fix: fillMissingTokenAddress function doesn't work as expected #422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The return conditions in
fillMissingTokenAddress
incorrectly trigger an exit whentoken.L1
ortoken.L2
are null. The intended behavior should only allow an exit if a non-null, non-zeroAddresstoken.L1
is found, and thus the function exhausts all possibilities before terminating. I believe this was a mistake that went undetected.Changes:
Checklist