Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix MaxNbCircuitsSum test #22

Merged
merged 2 commits into from
Sep 12, 2024
Merged

fix MaxNbCircuitsSum test #22

merged 2 commits into from
Sep 12, 2024

Conversation

Tabaie
Copy link
Contributor

@Tabaie Tabaie commented Sep 11, 2024

This PR fixes the occasional failure of TestMaxNbCircuitsSum. The failure was caused by the test itself, since it sometimes created public input interconnection circuits with no execution circuits allowed. The interconnection circuit (reasonably) assumes that there is at least one.

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully run tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any. (N/A)

@Tabaie Tabaie requested a review from gusiri September 11, 2024 18:51
@gusiri
Copy link
Contributor

gusiri commented Sep 11, 2024

pi-interconnection % go test -run ^TestMaxNbCircuitsSum$

INFO[0000] defining the constraints of the GKR verifier 
INFO[0002] defining the constraints of the GKR verifier : done 
INFO[0002] defining the constraints of the GKR verifier 
INFO[0005] defining the constraints of the GKR verifier : done 
INFO[0005] defining the constraints of the GKR verifier 
INFO[0007] defining the constraints of the GKR verifier : done 
INFO[0007] defining the constraints of the GKR verifier 
INFO[0009] defining the constraints of the GKR verifier : done 
INFO[0009] defining the constraints of the GKR verifier 
INFO[0011] defining the constraints of the GKR verifier : done 
+ provides the correct number of public inputs: OK, passed 5 tests.
Elapsed time: 11.151526625s
PASS
ok      github.com/consensys/linea-monorepo/prover/circuits/pi-interconnection  12.122s

LGTM

@Tabaie Tabaie enabled auto-merge (squash) September 11, 2024 19:01
@Tabaie Tabaie requested a review from gbotrel September 11, 2024 19:01
@Tabaie Tabaie merged commit 0f57a8d into main Sep 12, 2024
14 of 16 checks passed
@Tabaie Tabaie deleted the prover/fix/maxnbcircuitssum-test branch September 12, 2024 15:04
Copy link

Delta Summary - Kotlin Code Coverage

Generated on: 09/12/2024 - 15:04
Description Previous Current Delta
Coverage date: 09/12/2024 - 15:04 09/12/2024 - 15:04
Tag: 68_10833318519 68_10833318519
Line coverage: 27.6% 27.6% 0.0%
Covered lines: 26073 26073 0
Coverable lines: 94280 94280 0
Total lines: 133202 133202 0
Branch coverage: 10.5% 10.5% 0.0%
Covered branches: 5638 5638 0
Total branches: 53419 53419 0
Method coverage: Feature is only available for sponsors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants