-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(explorer): As a user, I want to see a card view of my Attestations #778
Merged
satyajeetkolhapure
merged 6 commits into
dev
from
feat/as-a-user-i-want-to-see-a-card-view-of-my-attestations
Oct 29, 2024
Merged
feat(explorer): As a user, I want to see a card view of my Attestations #778
satyajeetkolhapure
merged 6 commits into
dev
from
feat/as-a-user-i-want-to-see-a-card-view-of-my-attestations
Oct 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyajeetkolhapure
requested review from
alainncls,
orbmis and
arthur-remy
as code owners
October 24, 2024 11:50
satyajeetkolhapure
changed the title
feat (explorer): As a user, I want to see a card view of my Attestations
feat(explorer): As a user, I want to see a card view of my Attestations
Oct 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #778 +/- ##
=======================================
Coverage 46.64% 46.64%
=======================================
Files 18 18
Lines 388 388
Branches 57 57
=======================================
Hits 181 181
Misses 205 205
Partials 2 2 ☔ View full report in Codecov by Sentry. |
satyajeetkolhapure
force-pushed
the
feat/as-a-user-i-want-to-see-a-card-view-of-my-attestations
branch
from
October 25, 2024 16:39
2178264
to
e2f0195
Compare
alainncls
requested changes
Oct 29, 2024
explorer/src/pages/Attestation/components/AttestationCard/index.tsx
Outdated
Show resolved
Hide resolved
explorer/src/pages/Attestation/components/AttestationCard/index.tsx
Outdated
Show resolved
Hide resolved
explorer/src/pages/Attestation/components/AttestationCard/index.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Alain Nicolas <[email protected]>
alainncls
approved these changes
Oct 29, 2024
satyajeetkolhapure
deleted the
feat/as-a-user-i-want-to-see-a-card-view-of-my-attestations
branch
October 29, 2024 16:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A new attestation card view is added.
It is shown on my attestations page and also on attestation details subject field onclick event
Related ticket
Fixes #703
Type of change
Check list