Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch sumchecks in a Wire bundle #1248

Draft
wants to merge 31 commits into
base: master
Choose a base branch
from
Draft

Batch sumchecks in a Wire bundle #1248

wants to merge 31 commits into from

Conversation

amit0365
Copy link

@amit0365 amit0365 commented Aug 15, 2024 •
edited
Loading

Description

Added interface wireBundle to batch multiple sumchecks for different output wires in a single layer

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

  • TestMultipleDblAddSelectGKR

How has this been benchmarked?

  • Benchmark A, on Macbook pro M1, 32GB RAM
  • Benchmark B, on x86 Intel xxx, 16GB RAM

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

amit0365 and others added 30 commits June 11, 2024 21:53
gkr_nonnative intial review
b1a4c73
removed unused fns
2825fdc
added some tests
94a6866
Debugged nil elements -m added verifier in claimsmaanager and popoula…
6cbdc74 
…ted it in verify -m using emulated.assertequal in verify -m removed unused frombits in element as @arya pointed -m
Revert "Debugged nil elements -m added verifier in claimsmaanager and…
2b30342 
… popoulated it in verify -m using emulated.assertequal in verify -m removed unused frombits in element as @arya pointed -m"

This reverts commit 6cbdc74.
git commit -m "Debugged nil elements" -m "Added verifier in ClaimsMan…
ac3b04e 
…ager and populated it in verify" -m "Removed unused fromBits in Element"
Debugged nil elements
59c8554 
Added verifier in ClaimsManager and populated it in verify

Using emulated.Assertequal in verify

Removed unused fromBits in Element
removed unused fns
650d48a
compiles now
4717901
fixed
04b5caf
@TheDarkMatters
resolve ivo comments - prover done
9a6f78c
@amit0365
fixed ivo comments
a8917d9
@amit0365
removed Fr naming with Emulated
5224fac
@amit0365
removed all Fr with Emulated
4720856
@amit0365
testing single add gate
218c27a
@amit0365
testgkrvector fails, debug
6670c2d
@amit0365
arya review test
043048b
@amit0365
fixed single_identity_gate_two_instances prove, renamed partialSumPol…
0da71f7 
…ys to RoundPolyEvals
@amit0365
single identity gate passes testgkr
93e787c
@amit0365
testgkr passes
b091b79
@amit0365
commented print patch
81335d7
@amit0365
changes from gofmt
29c23c5
@amit0365
fixed lint
3a72147
@amit0365
removed TestLogNbInstances
b34071a
@amit0365
dbladdgkr passes
47bad48
@amit0365
input layer doesn't work
33011f8
@amit0365
manyInstances works
fe46739
@amit0365
passes with random inputs
14d12b4
@amit0365
eq common in next and computeGJ
1cf2c2d
@amit0365
cleanup
de475cd
@amit0365 amit0365 requested review from ivokub and gbotrel August 15, 2024 00:37
@CLAassistant
Copy link

CLAassistant commented Aug 15, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ TheDarkMatters
❌ amit0365

amit0365 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivokub ivokub Awaiting requested review from ivokub

@gbotrel gbotrel Awaiting requested review from gbotrel

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amit0365 @CLAassistant @TheDarkMatters