Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch sumchecks in a Wire bundle #1248

Draft
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

amit0365
Copy link

@amit0365 amit0365 commented Aug 15, 2024

Description

Added interface wireBundle to batch multiple sumchecks for different output wires in a single layer

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

  • TestMultipleDblAddSelectGKR

How has this been benchmarked?

  • Benchmark A, on Macbook pro M1, 32GB RAM
  • Benchmark B, on x86 Intel xxx, 16GB RAM

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

amit0365 and others added 30 commits June 11, 2024 21:53
…ted it in verify -m using emulated.assertequal in verify -m removed unused frombits in element as @arya pointed -m
… popoulated it in verify -m using emulated.assertequal in verify -m removed unused frombits in element as @arya pointed -m"

This reverts commit 6cbdc74.
…ager and populated it in verify" -m "Removed unused fromBits in Element"
Added verifier in ClaimsManager and populated it in verify

Using emulated.Assertequal in verify

Removed unused fromBits in Element
@amit0365 amit0365 requested review from ivokub and gbotrel August 15, 2024 00:37
@CLAassistant
Copy link

CLAassistant commented Aug 15, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ TheDarkMatters
❌ amit0365


amit0365 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants