fix: conditional check in non-native IsZero for applying optimization (…

…#1145) * fix: IsZero optimization conditional * chore: update stats
Consensys · Jul 18, 2024 · d738f08 · d738f08
1 parent de4fa56
commit d738f08
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/internal/stats/latest.stats b/internal/stats/latest.stats
diff --git a/std/math/emulated/field_assert.go b/std/math/emulated/field_assert.go
@@ -111,7 +111,7 @@ func (f *Field[T]) IsZero(a *Element[T]) frontend.Variable {
 	// as ca is already reduced, then every limb overflow is already 0. Only
 	// every addition adds a bit to the overflow
 	totalOverflow := len(ca.Limbs) - 1
-	if totalOverflow < int(f.maxOverflow()) {
+	if totalOverflow > int(f.maxOverflow()) {
 		// the sums of limbs would overflow the native field. Use the first
 		// approach instead.
 		res := f.api.IsZero(ca.Limbs[0])