Skip to content

Commit

Permalink
Merge pull request #40 from Consensys/cleanup-token-vars
Browse files Browse the repository at this point in the history
update to remove unused inputs
  • Loading branch information
joshuafernandes authored Sep 17, 2024
2 parents 8f740e7 + 71e5c80 commit 9a29f8c
Show file tree
Hide file tree
Showing 8 changed files with 3 additions and 41 deletions.
5 changes: 0 additions & 5 deletions build/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,6 @@
name: 'build'
description: 'Composite action to build the docs'

inputs:
GITHUB_TOKEN:
description: 'Github secret Token'
required: true

runs:
using: "composite"
steps:
Expand Down
7 changes: 0 additions & 7 deletions case/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ inputs:
description: "default directory path from project root"
required: false
default: docs
GITHUB_TOKEN:
description: "token to run with correct permissions"
required: true
SKIP_TEST:
description: "set to true to skip case test"
required: false
Expand Down Expand Up @@ -44,7 +41,3 @@ runs:
echo "Wrong example: My-Folder/MyFile-NAME.old.md"
exit 1
fi
env:
# Required, set by GitHub actions automatically:
# https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret
GITHUB_TOKEN: ${{ inputs.GITHUB_TOKEN }}
5 changes: 0 additions & 5 deletions dependency-review/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,6 @@
---
name: 'Dependency Review'

inputs:
GITHUB_TOKEN:
description: 'Github secret Token'
required: true

runs:
using: "composite"
steps:
Expand Down
3 changes: 0 additions & 3 deletions lint-markdown/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ name: 'lint: markdown'
description: 'Composite action to lint markdown'

inputs:
GITHUB_TOKEN:
description: 'Github secret Token'
required: true
CONFIG_FILE:
description: 'markdownlint config file'
required: false
Expand Down
5 changes: 0 additions & 5 deletions lint/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,6 @@
name: 'test: lint all code'
description: 'Composite action to lint all kind of files'

inputs:
GITHUB_TOKEN:
description: 'Github secret Token'
required: true

runs:
using: "composite"
steps:
Expand Down
3 changes: 0 additions & 3 deletions mm-security-scanner/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ name: 'MetaMask Security Code Scanner'
description: 'MetaMask Security Code Scanner'

inputs:
GITHUB_TOKEN:
description: 'Github secret Token'
required: true
SECURITY_SCAN_METRICS_TOKEN:
description: 'Metrics token'
required: true
Expand Down
8 changes: 1 addition & 7 deletions spelling/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ name: 'test: spelling'
description: 'Composite action to test spelling'

inputs:
GITHUB_TOKEN:
description: 'Github secret Token'
required: true
FILEPATHS:
description: 'Filepaths to look at, specified as a comma separated string ie "docs,blog,etc"'
required: false
Expand All @@ -29,9 +26,6 @@ runs:
vale_flags: "--config .docs-gha/spelling/.vale.ini --glob={*.md,*.mdx}"
# fail_on_error: true
reporter: github-pr-check
env:
# Required, set by GitHub actions automatically:
# https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret
GITHUB_TOKEN: ${{ inputs.GITHUB_TOKEN }}



8 changes: 2 additions & 6 deletions trivy/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,6 @@
name: 'Trivy'
description: 'Composite action to run trivy on the npm package.json'

inputs:
GITHUB_TOKEN:
description: 'Github secret Token'
required: true

runs:
using: "composite"
steps:
Expand All @@ -30,4 +25,5 @@ runs:
- name: Upload Trivy scan results to GitHub Security tab
uses: github/codeql-action/upload-sarif@v3
with:
sarif_file: 'trivy-results.sarif'
sarif_file: 'trivy-results.sarif'

0 comments on commit 9a29f8c

Please sign in to comment.