Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc: Reown and Primus Branding Integration #895

Closed
wants to merge 28 commits into from

Conversation

qvkare
Copy link
Contributor

@qvkare qvkare commented Dec 11, 2024

This update incorporates changes to reflect the recent rebranding and new integrations for both "Reown" and "Primus" protocols in the documentation.

Changes Summary:

  1. Title Updates:

    • Changed the title from "WalletConnect" to "Reown."
    • Added references to "Primus" where relevant to reflect the inclusion of its functionality.
  2. Image Updates:

    • Updated image paths to reflect new branding:
      • walletconnect.jpg updated to reown.jpg.
      • Added primus.jpg for pages that introduce or highlight Primus functionalities.
  3. Text Updates:

    • Replaced all instances of "WalletConnect" with "Reown."
    • Added "Primus" alongside relevant mentions of Reown to showcase its role in cryptographic attestations and privacy-preserving computations.
    • Updated links to the new Reown Cloud, the official Reown website, and Primus Labs.
  4. Content Additions:

    • Included descriptions of Primus's advanced cryptographic solutions (zkTLS and zkFHE) in relevant sections.
    • Highlighted the collaboration between Reown and Primus in enabling secure, privacy-preserving, and decentralized integrations.
  5. Consistency Improvements:

    • Ensured all links and mentions align with the respective new brands.
    • Verified that references to "Primus" and "Reown" use updated terminology and maintain clarity across the documentation.

Key Updated Links:

This update aligns the documentation with both Reown’s and Primus’s latest branding efforts, ensuring a cohesive and modern representation of the protocols.

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doc-zk-evm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 0:04am

Copy link

vercel bot commented Dec 11, 2024

@qvkare is attempting to deploy a commit to the Consensys Team on Vercel.

A member of the Team first needs to authorize it.

@qvkare qvkare changed the title Update node size data Update doc: Reown and Primus Branding Integration Dec 11, 2024
Copy link
Collaborator

@jlwllmr jlwllmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to adjust. Also seeing if I can push up the necessary changes to the redirects as it's hard to make the suggestion on the PR

docs/get-started/tooling/attestations/primus.mdx Outdated Show resolved Hide resolved
docs/get-started/tooling/attestations/primus.mdx Outdated Show resolved Hide resolved
docs/get-started/tooling/attestations/primus.mdx Outdated Show resolved Hide resolved
docs/get-started/tooling/libraries/reown.mdx Show resolved Hide resolved
docs/get-started/tooling/libraries/reown.mdx Show resolved Hide resolved
docs/get-started/tooling/libraries/reown.mdx Show resolved Hide resolved
redirects.json Outdated Show resolved Hide resolved
@qvkare
Copy link
Contributor Author

qvkare commented Dec 12, 2024

I think we should add "Reown" to Vale's dictionary since it's causing spelling check errors in CI - I initially tried to work around this by adding "Protocol" suffix which wasn't the right approach.

@jlwllmr
Copy link
Collaborator

jlwllmr commented Dec 12, 2024

@qvkare I'll add it to my list to submit to the central GH action that Vale runs from — I tend to do this in batches. But we can merge even though it's flagging it as an error. It doesn't influence the build

Copy link
Contributor Author

@qvkare qvkare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edited Primus

Copy link
Contributor Author

@qvkare qvkare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix Documentation

@github-actions github-actions bot force-pushed the update-node-size-data branch from 2ba0aae to 458fdff Compare December 16, 2024 01:07
@jlwllmr
Copy link
Collaborator

jlwllmr commented Dec 16, 2024

@qvkare the state of the branch seems to have been reverted to its state before I last reviewed -- i.e. both protocols are still incorrectly capitalised in their respective files. Could you take a look at this please?

I suspect some of the problems might stem from using the update-node-size-data branch.

@qvkare qvkare closed this Dec 16, 2024
@qvkare qvkare deleted the update-node-size-data branch December 16, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Pado Labs page to Primus Labs Update WalletConnect page to Reown
2 participants