Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version: Mainnet funding instructions #386

Merged
merged 14 commits into from
Jan 10, 2024
Merged

Initial version: Mainnet funding instructions #386

merged 14 commits into from
Jan 10, 2024

Conversation

mapachurro
Copy link
Collaborator

Adding instructions for funding on Mainnet.

They likely need to be greatly augmented, but this gets users going.

Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doc-zk-evm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 2:31pm

@mapachurro
Copy link
Collaborator Author

The broken links are Thanks Elon Twitter 404s. Ready to merge.

Copy link
Collaborator

@jlwllmr jlwllmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the comments are essential changes (other than the suggestion that adds instructions for finding 'Buy' on desktop browsers), but I think it'd be good if you could review @mapachurro

docs/use-mainnet/fund.mdx Outdated Show resolved Hide resolved
docs/use-mainnet/fund.mdx Outdated Show resolved Hide resolved
docs/use-mainnet/fund.mdx Outdated Show resolved Hide resolved
docs/use-mainnet/fund.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@emilyJLin95 emilyJLin95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the most part I think what the others have put are good suggestions

I do want to note if you click the side bar "get test eth" while on the mainnet page it doesn't do anything (which is just a problem with the tab format in general)

I wonder if you can embed the tabs inside somehow so the headers appear for both mainnet and testnet equally and will correctly fast navigate?

Similar how we do Infura vs. public endpoint underneath the header rather than as a header
https://docs.linea.build/build-on-linea/quickstart/deploy-smart-contract/hardhat

Copy link
Collaborator

@jlwllmr jlwllmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jlwllmr jlwllmr merged commit 1f0a781 into main Jan 10, 2024
6 of 7 checks passed
@jlwllmr jlwllmr deleted the fund-update branch January 10, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants