-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial version: Mainnet funding instructions #386
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The broken links are Thanks Elon Twitter 404s. Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of the comments are essential changes (other than the suggestion that adds instructions for finding 'Buy' on desktop browsers), but I think it'd be good if you could review @mapachurro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the most part I think what the others have put are good suggestions
I do want to note if you click the side bar "get test eth" while on the mainnet page it doesn't do anything (which is just a problem with the tab format in general)
I wonder if you can embed the tabs inside somehow so the headers appear for both mainnet and testnet equally and will correctly fast navigate?
Similar how we do Infura vs. public endpoint underneath the header rather than as a header
https://docs.linea.build/build-on-linea/quickstart/deploy-smart-contract/hardhat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Adding instructions for funding on Mainnet.
They likely need to be greatly augmented, but this gets users going.