Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge contract testing library #336

Merged
merged 221 commits into from
Sep 18, 2023
Merged

Merge contract testing library #336

merged 221 commits into from
Sep 18, 2023

Conversation

Bargsteen
Copy link
Contributor

@Bargsteen Bargsteen commented Sep 15, 2023 •
edited
Loading

Purpose

Merge the smart contract testing library into this repository.
This prepares us for migrating the old example tests to use the new testing library.

Changes

  • Merge in the library.
  • Replace the contracts-common submodule with the rust-sdk (since it is needed by the testing lib and contains the contracts-common lib via the base submodule)
  • Add a CI job for it that only runs when changes occur in the testing lib, the rust SDK or the rustfmt config file.
  • Update the readme to the new reality.
  • Checkout submodules recursively in the CI.
    • This is needed because the rust-sdk submodule has base as a submodule.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@Bargsteen
Add integration testing library
f737069
@Bargsteen
Implement bare-bones contract initialization
450f939
@Bargsteen
Add tests for contract init
6f5414b
@Bargsteen
Implement most of bare-bones smart contract update
5779fac
@Bargsteen
Finish up basic updates and add test
02e3d58
@Bargsteen
Add invoke method, helper methods, and begin handling interrupts
bb7b266
@Bargsteen
Remove optional contexts, implement naive handling of transfers
ab37629
@Bargsteen
Begin work on recursive handling of contracts
9a1b247
@Bargsteen
Refactor processing of receive calls
225e347
@Bargsteen
Handle fallback entrypoints and add more checks in test
0820cef
@Bargsteen
Handle rollbacks of top-level transactions
b2fafc3
@Bargsteen
Charge for module lookup
c909d3c
@Bargsteen
Restructure to use an internal aux function
47b30c6 
A step towards handling invoke_contract interrupts
@Bargsteen
Handle recursive invokes (but with state-related bugs)
5268cf4
@Bargsteen
Handle state on recursion without rollbacks
69ca9e2
@Bargsteen
Collect chain events, improve debug printing, add rollback test
2efbbea
@Bargsteen
Only save chain events for successful sub calls
9250ed3
@Bargsteen
Implement the account balance query
9db1a17
@Bargsteen
Add module_deploy_raw which takes a raw wasm module
2bb7a2f
@Bargsteen
Only add interrupt events for transfers and calls
af8ae0b
@Bargsteen
Add tests for account balance (from scheduler tests)
7f286ea 
The tests should be moved to concordium-base so that they can be used here.
@Bargsteen
Implement contract balance query
f0c72df
@Bargsteen
Add actual exchange rates used by chain
fad5062
@Bargsteen
Use simpler exchange rate ratio to avoid overflow
803b35b
@Bargsteen
Implement querying exchange rates
82e4eda
@Bargsteen
Improve deployment cost calculation
b018006 
However, it still doesn't exactly match concordium-client or the node (which
differ internally).
@Bargsteen
Implement contract upgrades
cef63a6
@Bargsteen
Add remaining contract upgrade tests
b9fe562
@Bargsteen
Remove direct CCC dependency, make fields pub, add docs
cc1ddcf
@Bargsteen
Fix deploy module NRG calculation and allow custom acc sig count
bf277a9
Bargsteen and others added 17 commits September 12, 2023 11:14
@Bargsteen
Fix fmt and clippy warnings
d7c4489
@Bargsteen
Fix test warnings
94650fc
@Bargsteen
Merge branch 'kb/external-node-exchange-rates-block-time' into kb/ext…
38e5634 
…ernal-view
@Bargsteen
Take ownership to match convention of to_* methods
f82b17f
@Bargsteen
Bump MSRV to 1.66 and use immutable references
92808d6
@Bargsteen
Merge branch 'kb/external-node-exchange-rates-block-time' into kb/ext…
35b701a 
…ernal-view
@Bargsteen
Use correct reference type
2e0c53b
@Bargsteen
Make small clarifications
3c73241
@Bargsteen
Align lines
ed3749a
@Bargsteen
Merge pull request #91 from Concordium/kb/external-node-exchange-rate…
961b87f 
…s-block-time

Add methods for setting exchange rates via external node
@Bargsteen @DOBEN @limemloh
Apply suggestions from code review
a3a664c 
Co-authored-by: Doris Benda <[email protected]>
Co-authored-by: Emil Holm Gjørup <[email protected]>
@Bargsteen
Fix formatting
c753779
@Bargsteen
Merge pull request #102 from Concordium/kb/external-view
b41d15a 
Invoke external contracts
@Bargsteen
Merge remote-tracking branch 'testing/main'
e6cae39
@Bargsteen
Add rust-sdk submodule and update paths to contracts-common
4c3a061
@Bargsteen
Add CI job for the testing library
30d3dfe
@Bargsteen
Update README with the new changes
37519e8
@Bargsteen Bargsteen changed the title Kb/merge contract testing lib Merge contract testing library Sep 15, 2023
@Bargsteen Bargsteen mentioned this pull request Sep 15, 2023
Merged
6 tasks
limemloh
limemloh approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@limemloh limemloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.gitmodules Outdated Show resolved Hide resolved
@Bargsteen Bargsteen mentioned this pull request Sep 15, 2023
Closed
23 tasks
@Bargsteen @limemloh
Use relative path for submodule.
fea3635 
This allows the user to use either https or ssh.

Co-authored-by: Emil Holm Gjørup <[email protected]>
@Bargsteen Bargsteen merged commit 7dc481a into main Sep 18, 2023
131 checks passed
@Bargsteen Bargsteen deleted the kb/merge-contract-testing-lib branch September 18, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abizjak abizjak abizjak approved these changes

@limemloh limemloh limemloh approved these changes

@DOBEN DOBEN Awaiting requested review from DOBEN

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bargsteen @abizjak @limemloh @DOBEN