Skip to content

Commit

Permalink
fix(shader_file): correctly parse incl. shaders that are statement lists
Browse files Browse the repository at this point in the history
Previously, when an include shader contained a statement list, only the
first statement in the AST would be transpiled, which broke the shader,
and is likely to be a common use case (I've seen it happen on objmc).
  • Loading branch information
AlexTMjugador committed Oct 7, 2023
1 parent a44d173 commit 886cbe5
Show file tree
Hide file tree
Showing 4 changed files with 87 additions and 101 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ Versioning](https://semver.org/spec/v2.0.0.html).
statements or expressions. Failure to parse them as such will result in a
tentative syntax error to be shown, but such an error will not be fatal and
PackSquash will fall back to no source transformation.
- Include shaders consisting of a list of statements no longer have only their
first instruction transformed when minifying or prettifying, which broke the
semantics of the shader code.
- The UTF-8 BOM is no longer automatically stripped from properties files, as
they should not be encoded in UTF-8 to begin with, and carrying on processing
with mismatched encodings may cause mojibake.
Expand Down
Loading

0 comments on commit 886cbe5

Please sign in to comment.