T1894 improve error messages on scan import letters #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 21, 2024 14:31
… True on analysis failure
…not pass the test
… passes to failed
|
ecino
requested changes
Nov 18, 2024
Comment on lines
+309
to
+313
| self.import_completed = False | ||
| self.failed_file_name = file_name | ||
| self.state = "failed" | ||
| self.env.user.notify_danger(f"Couldn't import file {file_name}") | ||
| self._compute_state = False |
There was a problem hiding this comment.
A call to the write method is preferable when changing many values at the same time. Also assigning the compute method seems wrong.
Suggested change
| self.import_completed = False | |
| self.failed_file_name = file_name | |
| self.state = "failed" | |
| self.env.user.notify_danger(f"Couldn't import file {file_name}") | |
| self._compute_state = False | |
| self.write({ | |
| "import_completed": False, | |
| "failed_file_name": file_name, | |
| "state": "failed" | |
| }) | |
| self.env.user.notify_danger(f"Couldn't import file {file_name}") |
There was a problem hiding this comment.
when I remove the line "self._compute_state = False" the import is recalculated and the import state is set to ready instead of failed
There was a problem hiding this comment.
Can you then please put this as a comment above the line in order to explain the reason of this line? Otherwise won't understand and may remove it in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve error messages on scan import letters