Christmas gift can be generated even without being active #1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ecino
requested changes
Nov 18, 2024
| @@ -43,10 +43,11 @@ def _generate_invoices(self, invoicer, contract_id=None): | |||
| super( | |||
| ContractGroup, self.with_context(open_invoices_sponsorship_only=True) | |||
| )._generate_invoices(invoicer, contract_id) | |||
| # We can generate christmas even if the contract isn't active as it is a fund. | |||
| self.mapped("contract_ids")._generate_gifts(invoicer, CHRISTMAS_GIFT) | |||
There was a problem hiding this comment.
This would also generate gifts for terminated contracts, do we want to avoid it? I would propose to keep a filter but maybe only keep waiting and active contracts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Christmas gift being a fund does not need to wait for being activate before generating invoices.
This change is already on the nordic prod