Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] Rr/17.0 gift compassion #1983

Open
wants to merge 4 commits into
base: 17.0
Choose a base branch
from
Open

Conversation

robinrolle
Copy link

CODE NOT TESTED LOCALLY due to lack of data.

Migration changes for gift_compassion module.

Changes required by OCA as been applied

Refactored data/base_automation.xml. Fields state and code from base.automation are not supported anymore.

Model account.analytic.tag is not supported as well and has been replaced by account.analytic.distribution.

Copy link

sonarcloud bot commented Oct 17, 2024

@robinrolle robinrolle changed the title Rr/17.0 gift compassion [MIG] Rr/17.0 gift compassion Oct 17, 2024
@robinrolle robinrolle self-assigned this Oct 17, 2024
@ecino
Copy link
Member

ecino commented Nov 18, 2024

In the file sponsoship_gift.py the analytic tags are used but the code is left the same as in v14. I think it needs to be adapted to the changes in v17 to the distribution. We may also need a migration script in order to FIX the ids of the settings no, or at least unset them so that we can reset them properly after migration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants