T1721 - Generate gift wizard uses the wrong partner #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecino
requested changes
Aug 19, 2024
There was a problem hiding this comment.
The problem is that the field send_gifts_to is declared in the module sponsorship_compassion, which is a child from this module. Therefore, this field is not accessible from the module recurring_contract which could be theoretically installed without sponsorship_compassion. The fix has to be done inside the module sponsorship_compassion or any of its children.
|
|
I've edited this PR to create a trivial method to get the |
ecino
approved these changes
Aug 19, 2024
ecino
pushed a commit
that referenced
this pull request
Aug 27, 2024
* fix: use send_gifts_to if available * feat: add a way to override the partner for a contract --------- Co-authored-by: Clément <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the invoice for the
send_gifts_totarget, defaults topartner_idif not set.Note: The first contract is used to get
send_gifts_to, as the current code does for other fields.CompassionCH/compassion-modules#1949