Added normalization for predictions. #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CompRhys
reviewed
Nov 10, 2024
There was a problem hiding this comment.
The aleatoric uncertainties would also need to be denormed
There was a problem hiding this comment.
I think line 108 handles that case as well, as in case the model is robust, preds will contain both (line 113) -
preds, aleat_log_std = preds.TThere was a problem hiding this comment.
Hi, I understand the problem you are pointing out, have added a fix.
CompRhys
reviewed
Nov 13, 2024
aviary/predict.py
Outdated
| # denorm the mean and aleatoroc uncertainties separately | ||
| mean, log_std = np.split(preds, 2, axis=1) | ||
| preds = normalizer.denorm(mean) | ||
| ale_std = np.exp(log_std) * normalizer.std |
There was a problem hiding this comment.
we need to put this back to the log space here based on the logic below.
There was a problem hiding this comment.
I would think it would be less code to just add the normalizer into the logic below rather than having to make a new logic block.
|
Hi, I agree with both of your suggestions. I made the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #90. I have only added a few lines of code in
predict.pyso that Roost models can be used for prediction later.