Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: host GitHub Pages on fork as PR preview #21

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Conversation

redeboer
Copy link
Member

Currently, the documentation CI job runs only on PRs and (naturally) the build files are only hosted from the main branch of ComPWA/strong2020-salamanca. This PR should make it possible to run the doc job on pushes to your fork and then directly host the build files for the GitHub pages of your fork (you need to configure the pages to be published from a workflow and remove the environment restrictions so that the pages can be published from other branches than your main branch).

This PR is motivated by https://github.com/ComPWA/RUB-EP1-AG/issues/78.

@redeboer redeboer added the 🖱️ DX Improvements to the Developer Experience label Oct 19, 2023
@redeboer redeboer self-assigned this Oct 19, 2023
@redeboer
Copy link
Member Author

@shenvitor could you create a fork and push this branch to check if you can build a preview?

@shenvitor
Copy link
Member

@shenvitor could you create a fork and push this branch to check if you can build a preview?

Test is running:
https://github.com/shenvitor/strong2020-salamanca/actions/runs/6575276252

@redeboer redeboer changed the title DX: host GitLab pages on fork as PR preview DX: host GitHub Pages on fork as PR preview Oct 19, 2023
Copy link
Member

@shenvitor shenvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@shenvitor shenvitor marked this pull request as ready for review October 19, 2023 13:35
@shenvitor shenvitor merged commit 94c273b into ComPWA:main Oct 19, 2023
8 checks passed
@redeboer redeboer deleted the fork-ci branch October 19, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖱️ DX Improvements to the Developer Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants