Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: automatically update pip install cell metadata #218

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

redeboer
Copy link
Member

Jupyter notebooks (especially the TRs) require a pip install statement and those have specific metadata that needs to be set. Previously, you would have to set this metadata manually, which was annoying. With this PR, the cell is automatically unhidden (policy change) and the cell is removed from the Sphinx build.

Note: we unhide the cell, because hidden cells with one line render almost exactly the same as unhidden ones in Jupyter Lab v4:
image
image

@redeboer redeboer added ❗ Behavior Changes that may affect the framework output ⚙️ Enhancement Improvements and optimizations of existing features labels Nov 20, 2023
@redeboer redeboer requested a review from shenvitor November 20, 2023 14:02
@redeboer redeboer self-assigned this Nov 20, 2023
@redeboer redeboer marked this pull request as ready for review November 20, 2023 14:10
@redeboer redeboer marked this pull request as draft November 20, 2023 14:10
@redeboer redeboer marked this pull request as ready for review November 20, 2023 14:10
@redeboer redeboer merged commit 1da9190 into main Nov 20, 2023
21 checks passed
@redeboer redeboer deleted the unhide-pip-install-cell branch November 20, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❗ Behavior Changes that may affect the framework output ⚙️ Enhancement Improvements and optimizations of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants