FIX: fix is_integer() bug for QRules v0.10.4
#450
+118
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pform into hotfix_fraction_is_integer_bug
This was referenced Jan 17, 2025
|
Apparantly, the |
redeboer
changed the title
Fraction in Python < 3.12is_integer() bug for QRules v0.10.4
redeboer
requested changes
Jan 17, 2025
There was a problem hiding this comment.
This test can be removed. The tests did catch the problem after ComPWA/actions#124 was fixed. See
https://github.com/ComPWA/ampform/actions/runs/12827104659/job/35770967572
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #449
Fixed a bug where the method
Fraction.is_integer(), which has only been added Python 3.12, is called when the angular momentum of a particle is notNone.Related issues that this PR addresses:
pytestalways runs with pinned Python versions actions#124uv.lockfiles policy#490pygmentsversion constraint policy#493