Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protein-specific coordinates based on index groups #666

Merged
merged 7 commits into from
Nov 8, 2024

Conversation

jhenin
Copy link
Member

@jhenin jhenin commented Feb 27, 2024

The goal is to make the alpha_angles CVC (and dihedralPC) available on all back-ends.

TODO:

  • allow for series of groups to describe non-contiguous alpha segments
  • extend to dihedralPC
  • update documentation
  • regression & unit tests
  • VMD Dashboard template (non blocking)

@jhenin jhenin marked this pull request as draft February 27, 2024 08:13
@jhenin jhenin changed the title First version, not fully functional yet Protein-specific coordinates based on index groups Feb 27, 2024
@giacomofiorin
Copy link
Member

A general comment: besides making those functions more portable there would be major advantages in making all CVCs rely on atom groups.

I think it would be great to just use the three groups groupCA, groupN and groupO consistently in all backends, and just have VMD and NAMD auto-fill them to preserve backward compatibility.

While working on #644 I realized that when that is done, CVCs that are based on centers of mass could easily be used any positions, including individual atoms. This would much simplify the data structures of the alpha and dihedPC.

@jhenin jhenin force-pushed the protein_cv_index_files branch 2 times, most recently from 8a50463 to b07996a Compare March 17, 2024 20:58
@jhenin
Copy link
Member Author

jhenin commented Apr 5, 2024

About making the groups groupCA, groupN and groupO generic: I realized that for the alpha CVC, we need to let the user specify several individual ranges of residues to track different alpha-helical segments. This is not compatible with having a single generic name for the index groups.

I don't get the comment about CVCs based on COMs being able to use individual atoms - isn't that already the case?

@jhenin jhenin force-pushed the protein_cv_index_files branch from b07996a to cb738d8 Compare April 5, 2024 17:20
@jhenin jhenin force-pushed the protein_cv_index_files branch from cb738d8 to 5aba970 Compare July 10, 2024 15:10
@jhenin jhenin added the GROMACS label Sep 13, 2024
@jhenin jhenin force-pushed the protein_cv_index_files branch from 5aba970 to 322d9f7 Compare November 7, 2024 17:43
@jhenin jhenin force-pushed the protein_cv_index_files branch from 322d9f7 to 6359abc Compare November 7, 2024 17:54
@jhenin jhenin marked this pull request as ready for review November 7, 2024 20:11
Copy link
Member

@giacomofiorin giacomofiorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation could be improved, but I think the people who would use a template input would far outnumber those who would write it from scratch.

I would merge it in the interest of time but allocate objects using smart pointers at some point.

doc/colvars-refman-main.tex Outdated Show resolved Hide resolved
@jhenin jhenin merged commit 118607e into master Nov 8, 2024
15 checks passed
@jhenin jhenin deleted the protein_cv_index_files branch November 8, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants