-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Silence Clang static analyzer warnings #582
Conversation
@HubLot I fixed a couple where the purpose of the code may not be immediately evident. Can you get the Clang command used so that we can add it to the CI for this PR? Easiest may be to add packages from Ubuntu (GH Actions) but we can also use the CentOS container. |
42dba19
to
1c18700
Compare
922acdc
to
f864906
Compare
I added a new CI job for the Clang analyzer. I fix some others warnings but it needs reviewing. Specially the one with the |
Thanks! I'll look at this and merge if appropriate. Sorry we don't have a uniform way to handle exit codes, we started adding them with the VMD integration (beginning ~2014 or so) but much of the code predates even that time. |
Fixes #581