Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event listeners for click and Enter key, and set tabIndex for accessibility #10924

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Darshan-upadhyay1110
Copy link
Contributor

  • Attach 'click' and 'keydown' event listeners to handle menu opening.
  • Ensure 'Enter' key triggers the same action as click.
  • Set tabIndex to '0' for improved keyboard navigation and accessibility.

Change-Id: Ib17eea8e2827542a1d5049766e7ee82d5f9270b3

  • Resolves: #
  • Target version: master

Summary

TODO

  • ...

Checklist

  • I have run make prettier-write and formatted the code.
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

@caolanm caolanm force-pushed the private/darshan/add-tabindex-for-arrowBackground branch from 95d13a5 to 2d815e9 Compare January 14, 2025 08:25
@Darshan-upadhyay1110 Darshan-upadhyay1110 force-pushed the private/darshan/add-tabindex-for-arrowBackground branch 4 times, most recently from 4429bf5 to 811c41c Compare January 15, 2025 17:00
…essibility

- Attach 'click' and 'keydown' event listeners to handle menu opening.
- Ensure 'Enter' key triggers the same action as click.
- Set tabIndex to '0' for improved keyboard navigation and accessibility.

Signed-off-by: Darshan-upadhyay1110 <[email protected]>
Change-Id: Ib17eea8e2827542a1d5049766e7ee82d5f9270b3
@Darshan-upadhyay1110 Darshan-upadhyay1110 force-pushed the private/darshan/add-tabindex-for-arrowBackground branch from 811c41c to 0431d23 Compare January 16, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Review
Development

Successfully merging this pull request may close these issues.

1 participant