Use a callback to handle dynamic getHttpHeader calls in testing #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 19 files - 16 427 suites - 348 4m 26s ⏱️ - 2m 45s For more details on these errors, see this check. Results for commit ccee9bd. ± Comparison against base commit 68f723a. ♻️ This comment has been updated with latest results. |
|
This looks like a good addition, can you create a ticket, and a test for it, please |
|
I still don't have a ticket or a test @gpickin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a POC to fix tests which fail due to headers not being dynamic.
This should solve the cbotel errors because it expects headers, or default values to work.
This has been painful for a while, especially in more dynamic testing flows.
I'll let you decide if its worth while or not to make a ticket etc.