Support BigNumber #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petejkim
reviewed
Mar 20, 2019
petejkim
reviewed
Mar 20, 2019
petejkim
reviewed
Mar 21, 2019
petejkim
reviewed
Mar 21, 2019
petejkim
reviewed
Apr 16, 2019
|
|
||
| // skip detrimental input | ||
| if (utxoFee > utxo.value) { | ||
| if (i === utxos.length - 1) return { fee: feeRate * (bytesAccum + utxoBytes) } | ||
| var feeIsMoreThanValue = ext.gt(utxoFee, utxoValue) |
petejkim
reviewed
Apr 16, 2019
|
|
||
| // would it waste value? | ||
| if ((inAccum + inputValue) > (outAccum + fee + threshold)) continue | ||
| var totalInputs = ext.add(inAccum, inputValue) |
petejkim
reviewed
Apr 16, 2019
|
|
||
| // did we bust? | ||
| if (inAccum < (outAccum + fee + value)) { | ||
| if (ext.lt(inAccum, ext.add(outAccum, fee, value))) { | ||
| var isZero = ext.isZero(outAccum) |
petejkim
reviewed
Apr 16, 2019
| if (outputs.length === 0) return { fee: fee } | ||
|
|
||
| var inAccum = utils.sumOrNaN(utxos) | ||
| var outAccum = utils.sumForgiving(outputs) | ||
| var remaining = inAccum - outAccum - fee | ||
| var remaining = ext.sub(inAccum, outAccum, fee) | ||
| if (!isFinite(remaining) || remaining < 0) return { fee: fee } |
petejkim
reviewed
Apr 16, 2019
| if (outputs.length === 0) return { fee: fee } | ||
|
|
||
| var inAccum = utils.sumOrNaN(utxos) | ||
| var outAccum = utils.sumForgiving(outputs) | ||
| var remaining = inAccum - outAccum - fee | ||
| var remaining = ext.sub(inAccum, outAccum, fee) | ||
| if (!isFinite(remaining) || remaining < 0) return { fee: fee } | ||
|
|
||
| var unspecified = outputs.reduce(function (a, x) { | ||
| return a + !isFinite(x.value) |
There was a problem hiding this comment.
looks like they really just wanted to do outputs.filter(x => !isFinite(x.value)).length
but wanted to maintain compatibility with old js
There was a problem hiding this comment.
but it also uses .every..so filter should have been fine...
petejkim
reviewed
Apr 16, 2019
|
|
||
| var splitOutputsCount = outputs.reduce(function (a, x) { | ||
| // Counts the number of split outputs left | ||
| var splitOutputsCount = new BN(outputs.reduce(function (a, x) { | ||
| return a + !x.value |
|
Why is this commit amended with BN changes: 339c1bf |
|
Moved to #2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the library to use ‘bn.js’ instead of number formats.
What has changed