Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU-8694vxbkh: Medcat v1.12 support #14

Merged
merged 5 commits into from
Oct 8, 2024
Merged

CU-8694vxbkh: Medcat v1.12 support #14

merged 5 commits into from
Oct 8, 2024

Conversation

mart-r
Copy link
Collaborator

@mart-r mart-r commented Jun 19, 2024

Remove use of deprecated method.

TODO:

  • Update requirements to medcat==1.12 (waiting on MedCAT release)

Copy link
Member

@tomolopolis tomolopolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mart-r
Copy link
Collaborator Author

mart-r commented Sep 19, 2024

NOTE:
There is an issue with this PR, regarding medcat/evaluate_mct_export/mct_analysis.py using the medcat.utils.meta_cat.data_utils.encode_category_values method (the signature of which was changed in MedCAT 1.12 due to PR 419).
Refer to CU task:
https://app.clickup.com/t/8695vz088

The medcat.utils.meta_cat.data_utils.encode_category_values  method has a different signature.
In working_with_cogstack, the medcat/evaluate_mct_export/mct_analysis.py  file relies on old behaviour.
@shubham-s-agarwal
Copy link
Collaborator

Added the change for below

NOTE: There is an issue with this PR, regarding medcat/evaluate_mct_export/mct_analysis.py using the medcat.utils.meta_cat.data_utils.encode_category_values method (the signature of which was changed in MedCAT 1.12 due to PR 419). Refer to CU task: https://app.clickup.com/t/8695vz088

Copy link
Member

@tomolopolis tomolopolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mart-r mart-r merged commit 08d65ed into main Oct 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants