Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options page #4

Merged
merged 9 commits into from
Feb 17, 2015
Merged

Options page #4

merged 9 commits into from
Feb 17, 2015

Conversation

ericwclymer
Copy link
Contributor

#3 is addressed by this.

  • It adds an options page
  • User can turn off shortcuts
  • User can turn on/off the cohort-year-adder
  • It starts using chrome sync to sync across devices where the user is signed in

I know I said I was done with the other PR, sorry.

Next step would be customizable shortcuts. I'm also considering adding (small?) images where cohort links are for users.

@CodyJung
Copy link
Owner

Would you go ahead and increment the version number, then assign this PR to me when you're ok with it?

@ericwclymer
Copy link
Contributor Author

I'm still messing around with this one. I probably shouldn't have created a PR yet.

I'll make sure to increment it.

You opposed to me adding my name to the author property?

@CodyJung
Copy link
Owner

Go for it!

@ericwclymer
Copy link
Contributor Author

Ok. I think i'm finally done for a while.

@ericwclymer
Copy link
Contributor Author

I can't figure out how to assign it 👎 sorry

@CodyJung CodyJung self-assigned this Feb 16, 2015
@CodyJung
Copy link
Owner

👍 I got it! I'll merge it and put together a new upload tomorrow (or later today, I guess it is...)

@CodyJung
Copy link
Owner

👍 Looks good to me! Seems to work.

CodyJung added a commit that referenced this pull request Feb 17, 2015
@CodyJung CodyJung merged commit 3450511 into CodyJung:master Feb 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants