fix rubocop and eslint warnings

Codeminer42 · Nov 7, 2023 · f2f452b · f2f452b
1 parent 1ef7f27
commit f2f452b
Show file tree

Hide file tree

Showing 5 changed files with 44 additions and 26 deletions.
diff --git a/app/assets/javascripts/actions/story.js b/app/assets/javascripts/actions/story.js
@@ -218,18 +218,26 @@ export const updateCollapsedStory =
     );
   };
 
-export const expandOrCollapseStory = (currentStory, from) => async (dispatch, _, { Story }) => {
-  if (!currentStory.collapsed) return dispatch(toggleStory(currentStory.id, from));
-
-  dispatch(setLoadingStory(currentStory.id, from));
-  try {
-    const { data } = await projectStoriesService.fetchStory(currentStory);
-    dispatch(updateStorySuccess({ ...Story.deserialize(data.story), ...currentStory }, from));
-    dispatch(toggleStory(currentStory.id, from));
-  } catch (error) {
-    dispatch(sendErrorNotification(error));
-  }
-};
+export const expandOrCollapseStory =
+  (currentStory, from) =>
+  async (dispatch, _, { Story }) => {
+    if (!currentStory.collapsed)
+      return dispatch(toggleStory(currentStory.id, from));
+
+    dispatch(setLoadingStory(currentStory.id, from));
+    try {
+      const { data } = await projectStoriesService.fetchStory(currentStory);
+      dispatch(
+        updateStorySuccess(
+          { ...Story.deserialize(data.story), ...currentStory },
+          from
+        )
+      );
+      dispatch(toggleStory(currentStory.id, from));
+    } catch (error) {
+      dispatch(sendErrorNotification(error));
+    }
+  };
 
 export const dragDropStory =
   (storyId, projectId, newAttributes, from) =>

diff --git a/app/assets/javascripts/services/stories.js b/app/assets/javascripts/services/stories.js
@@ -1,4 +1,4 @@
-import httpService from "./httpService";
+import httpService from './httpService';
 
 class ProjectStoriesService {
   async fetchStory(story) {

diff --git a/app/controllers/beta/project_boards_controller.rb b/app/controllers/beta/project_boards_controller.rb
@@ -6,7 +6,7 @@ def show
       project_id: params[:id],
       current_user: current_user,
       current_flow: cookies[:current_flow],
-      projects_scope: policy_scope(Project),
+      projects_scope: policy_scope(Project)
     )
 
     @project = result.success.project

diff --git a/app/operations/beta/project_board_operations/read.rb b/app/operations/beta/project_board_operations/read.rb
@@ -41,7 +41,7 @@ def create_project_board
           current_user: current_user,
           current_flow: current_flow,
           default_flow: default_flow,
-          labels: project_labels,
+          labels: project_labels
         )
 
         project_board = ::ProjectBoard.new(project_board_params)
@@ -54,8 +54,8 @@ def stories_and_past_iterations
         yield project_iterations
 
         yield Success(
-                stories: @active_stories,
-                past_iterations: past_iterations,
+          stories: @active_stories,
+          past_iterations: past_iterations
               )
       end
 
@@ -64,25 +64,35 @@ def active_stories
             project
               .stories
               .where("state != 'accepted' OR accepted_at >= ?", current_iteration_start)
-              .select(:id, :title, :description, :estimate, :story_type, :state, :requested_by_name, :owned_by_initials, :project_id)
-              .order("updated_at DESC")
+              .select(
+                :id,
+                :title,
+                :description,
+                :estimate,
+                :story_type,
+                :state,
+                :requested_by_name,
+                :owned_by_initials,
+                :project_id
+              )
+              .order('updated_at DESC')
           end
 
         Success(@active_stories)
       end
 
       def project_labels
         possibly_duplicated_labels = project.stories.map(&:labels).reject(&:blank?)
-        uniq_labels = possibly_duplicated_labels.join(",").split(",").uniq.join(",")
+        uniq_labels = possibly_duplicated_labels.join(',').split(',').uniq.join(',')
         uniq_labels
       end
 
       def project
         @project ||= current_user
-          .projects
-          .friendly
-          .preload(:users)
-          .find(project_id)
+                     .projects
+                     .friendly
+                     .preload(:users)
+                     .find(project_id)
       end
 
       def default_flow

diff --git a/app/operations/story_operations/read_all.rb b/app/operations/story_operations/read_all.rb
@@ -14,7 +14,7 @@ def call
 
       Success(
         active_stories: @active_stories,
-        past_iterations: past_iterations,
+        past_iterations: past_iterations
       )
     end
 
@@ -36,7 +36,7 @@ def active_stories
             .stories
             .with_dependencies
             .where("state != 'accepted' OR accepted_at >= ?", current_iteration_start)
-            .order("updated_at DESC")
+            .order('updated_at DESC')
         end
 
       Success(@active_stories)