-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: template cloud integration #2455
Conversation
Bundle Size Diff
|
Plugin build for da2f844 is ready 🛎️!
|
E2E TestsPlaywright Test Status: Performance ResultsserverResponse: 259.85, firstPaint: 583.3, domContentLoaded: 1568.05, loaded: 1568.7, firstContentfulPaint: 3551.8, firstBlock: 7978.55, type: 13.07, minType: 11.84, maxType: 15.35, typeContainer: 9.5, minTypeContainer: 8.04, maxTypeContainer: 11.7, focus: 34.72, minFocus: 30.59, maxFocus: 40.43, inserterOpen: 22.11, minInserterOpen: 19.97, maxInserterOpen: 24.45, inserterSearch: 0.69, minInserterSearch: 0.62, maxInserterSearch: 0.82, inserterHover: 2.8, minInserterHover: 2.56, maxInserterHover: 3.36, listViewOpen: 139.21, minListViewOpen: 128.21, maxListViewOpen: 160.28 |
@abaicus I had a chance to review this and here are some thoughts based on the updated implementation:
a) Display a link at the top like : https://vertis.d.pr/i/6Lt1sR, when clicked, it would open on the right some text explaining this + a link to the settings ( is this possible? b) Since most of users won't use this, we can display that link at the bottom, after the categories.
Eventually later on we can also encourage users to share their collections if they want or we can create some more, free or paid. To recap :
|
For the content on the right, do you have anything specific in mind, or can we go with something similar to what we'd have on 1, plus the link to settings?
|
|
99042ae
to
bdc5c30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left few observations.
@HardeepAsrani thanks for the suggestions! I've addressed them 👍🏻 |
Let's also add the external link icon to Premium designs and move on 3rd position This to make it clear that is a feature and not an external link or that is not "locked" |
🎉 This PR is included in version 3.0.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closes Codeinwp/templates-cloud#98.
Summary
Adds the new Template Cloud panel in the
Dashboard
page, underIntegrations
;Adds the new
Cloud Library
section in the Otter Library pattern inserter;Works in conjunction with https://github.com/Codeinwp/template-cloud-server/pull/1.
Screenshots
Dashboard / Integrations:
Editor / Pattern Library:
Test instructions
Checklist before the final review