Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added whitespace support to form's submit button #2440

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

girishpanchal30
Copy link
Contributor

Closes #2429

Summary

Added whitespace support

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@girishpanchal30 girishpanchal30 added the pr-checklist-skip Allow this Pull Request to skip checklist. label Nov 11, 2024
@girishpanchal30 girishpanchal30 linked an issue Nov 11, 2024 that may be closed by this pull request
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Nov 11, 2024
@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 271.41 KB 271.41 KB 0 B (0.00%)
Blocks 1.56 MB 1.56 MB -15 B (-0.00%)
CSS 100.89 KB 100.89 KB 0 B (0.00%)
Dashboard 198.45 KB 198.45 KB 0 B (0.00%)
Onboarding 161.1 KB 161.1 KB 0 B (0.00%)
Export Import 97.78 KB 97.78 KB 0 B (0.00%)
Pro 423.65 KB 423.65 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

Plugin build for 1fcb503 is ready 🛎️!

@pirate-bot
Copy link
Contributor

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 234.7, firstPaint: 542.45, domContentLoaded: 1545.85, loaded: 1546.75, firstContentfulPaint: 3400.15, firstBlock: 7570, type: 11.41, minType: 10.18, maxType: 13.08, typeContainer: 8.09, minTypeContainer: 7.26, maxTypeContainer: 11.14, focus: 31.79, minFocus: 28.23, maxFocus: 36.74, inserterOpen: 22.81, minInserterOpen: 19.43, maxInserterOpen: 35.69, inserterSearch: 0.69, minInserterSearch: 0.57, maxInserterSearch: 0.85, inserterHover: 3.15, minInserterHover: 2.53, maxInserterHover: 4.16, listViewOpen: 145.79, minListViewOpen: 128.58, maxListViewOpen: 158.63

@vytisbulkevicius vytisbulkevicius linked an issue Nov 12, 2024 that may be closed by this pull request
@vytisbulkevicius vytisbulkevicius merged commit 7ddf7f6 into development Nov 12, 2024
13 checks passed
@vytisbulkevicius vytisbulkevicius deleted the bugfix/2429 branch November 12, 2024 07:55
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Nov 12, 2024
@HardeepAsrani HardeepAsrani removed their request for review November 12, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't input a space in Form's submit button Change submit button text in Otter Form block
3 participants