Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use translation in block patterns #2414

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Oct 29, 2024

Closes https://github.com/Codeinwp/templates-cloud/issues/82

Summary

Swap the title of the registered pattern with its translated version if available.


Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel force-pushed the feat/translated-pattern-name branch from 1593703 to df2cfde Compare October 29, 2024 13:41
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Oct 29, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Oct 29, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review October 29, 2024 13:46
@pirate-bot
Copy link
Contributor

pirate-bot commented Oct 29, 2024

Plugin build for 7c756cf is ready 🛎️!

@pirate-bot
Copy link
Contributor

pirate-bot commented Oct 29, 2024

Bundle Size Diff

Package Old Size New Size Diff
Animations 271.41 KB 271.41 KB 0 B (0.00%)
Blocks 1.56 MB 1.56 MB 1 B (0.00%)
CSS 100.89 KB 100.89 KB 0 B (0.00%)
Dashboard 198.45 KB 198.45 KB 0 B (0.00%)
Onboarding 161.1 KB 161.1 KB 0 B (0.00%)
Export Import 97.78 KB 97.78 KB 0 B (0.00%)
Pro 423.65 KB 423.65 KB 0 B (0.00%)

@Soare-Robert-Daniel Soare-Robert-Daniel force-pushed the feat/translated-pattern-name branch from df2cfde to 0569ef3 Compare October 29, 2024 14:10
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Oct 29, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Oct 29, 2024

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 248.25, firstPaint: 543.35, domContentLoaded: 1595.55, loaded: 1596.2, firstContentfulPaint: 3592, firstBlock: 8165.45, type: 14.15, minType: 13.13, maxType: 15.11, typeContainer: 10.26, minTypeContainer: 7.68, maxTypeContainer: 14.01, focus: 35.11, minFocus: 29.33, maxFocus: 42.34, inserterOpen: 24.34, minInserterOpen: 21.97, maxInserterOpen: 29.27, inserterSearch: 0.9, minInserterSearch: 0.73, maxInserterSearch: 1.29, inserterHover: 4, minInserterHover: 2.69, maxInserterHover: 6.18, listViewOpen: 160.85, minListViewOpen: 141.69, maxListViewOpen: 230

@Soare-Robert-Daniel Soare-Robert-Daniel force-pushed the feat/translated-pattern-name branch from 723b55f to fe75f24 Compare October 29, 2024 14:59
@Soare-Robert-Daniel Soare-Robert-Daniel force-pushed the feat/translated-pattern-name branch from fe75f24 to 7c756cf Compare October 29, 2024 15:01
@Soare-Robert-Daniel Soare-Robert-Daniel merged commit e9ac2ad into development Oct 30, 2024
11 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the feat/translated-pattern-name branch October 30, 2024 07:30
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants