Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AI Toolbar visibility toggle in Dashboard #2268

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Jul 23, 2024

Closes https://github.com/Codeinwp/otter-internals/issues/206

Summary

Added a toggle for the AI Toolbar similar to the CSS module.

Screenshots

image


Test instructions

  1. Check the dashboard for the new toggle.
  2. Toggle it off, then check the Paragraphs block in the Post. It should be hidden.
  3. Re-enable the option and check again.

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Jul 23, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review July 23, 2024 11:12
@pirate-bot
Copy link
Contributor

pirate-bot commented Jul 23, 2024

Bundle Size Diff

Package Old Size New Size Diff
Animations 264.26 KB 264.26 KB 0 B (0.00%)
Blocks 1.52 MB 1.52 MB 174 B (0.01%)
CSS 93.5 KB 93.5 KB 0 B (0.00%)
Dashboard 195.83 KB 196.3 KB 487 B (0.24%)
Onboarding 153.95 KB 153.95 KB 0 B (0.00%)
Export Import 91.01 KB 91.01 KB 0 B (0.00%)
Pro 362.24 KB 362.24 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Jul 23, 2024

Plugin build for 922a821 is ready 🛎️!

@pirate-bot
Copy link
Contributor

pirate-bot commented Jul 23, 2024

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 235.05, firstPaint: 169.9, domContentLoaded: 1560.35, loaded: 1561, firstContentfulPaint: 3437.2, firstBlock: 6653.95, type: 10.98, minType: 10.09, maxType: 12.61, typeContainer: 7.77, minTypeContainer: 6.72, maxTypeContainer: 9.5, focus: 30.12, minFocus: 26.51, maxFocus: 36.84, inserterOpen: 23.85, minInserterOpen: 20.94, maxInserterOpen: 28, inserterSearch: 0.73, minInserterSearch: 0.63, maxInserterSearch: 0.95, inserterHover: 3.05, minInserterHover: 2.6, maxInserterHover: 4.25, listViewOpen: 147.59, minListViewOpen: 129.14, maxListViewOpen: 175.01

@carlalexander
Copy link
Collaborator

Everything looks good! Love that you have a test for the feature. 🐛🥳

My only request is can you merge all the commits under feat: add AI Toolbar visibility toggle.

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Jul 25, 2024
@carlalexander
Copy link
Collaborator

Looks good! Thanks @Soare-Robert-Daniel!

Copy link
Member

@HardeepAsrani HardeepAsrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one nit is that we can move the localized module flag from aiToolbarEnabled to hasModule that already contains other.

@Soare-Robert-Daniel Soare-Robert-Daniel merged commit 66ecaea into development Jul 30, 2024
11 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the fix/disable-ai-block branch July 30, 2024 10:09
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants