Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment with formats in the toolbar #2255

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

HardeepAsrani
Copy link
Member

@HardeepAsrani HardeepAsrani commented Jul 18, 2024

Closes https://github.com/Codeinwp/otter-internals/issues/208

Summary

This moves the Dynamic Link and Value from Format Dropdown to the main toolbar to improve visibility. It also changes the icon for Dynamic Link to avoid confusion.

Screenshots

Screenshot 2024-07-24 at 1 46 26 AM

Test instructions

  • Confirm the feature works as before with the new UI.

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@HardeepAsrani HardeepAsrani added the pr-checklist-skip Allow this Pull Request to skip checklist. label Jul 18, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Jul 18, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Jul 18, 2024

Bundle Size Diff

Package Old Size New Size Diff
Animations 264.2 KB 264.2 KB 0 B (0.00%)
Blocks 1.52 MB 1.52 MB 771 B (0.05%)
CSS 93.45 KB 93.45 KB 0 B (0.00%)
Dashboard 195.96 KB 195.96 KB 0 B (0.00%)
Onboarding 153.89 KB 153.89 KB 0 B (0.00%)
Export Import 90.96 KB 90.96 KB 0 B (0.00%)
Pro 362.19 KB 362.19 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Jul 18, 2024

Plugin build for 0350644 is ready 🛎️!

@pirate-bot
Copy link
Contributor

pirate-bot commented Jul 18, 2024

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 243.9, firstPaint: 138.6, domContentLoaded: 1561.1, loaded: 1562.15, firstContentfulPaint: 3500.35, firstBlock: 6777, type: 12.54, minType: 10.68, maxType: 15.75, typeContainer: 7.88, minTypeContainer: 6.73, maxTypeContainer: 9.97, focus: 29.32, minFocus: 25.94, maxFocus: 38.45, inserterOpen: 26.75, minInserterOpen: 21.14, maxInserterOpen: 50.34, inserterSearch: 0.7, minInserterSearch: 0.6, maxInserterSearch: 0.84, inserterHover: 3.88, minInserterHover: 3.22, maxInserterHover: 5.03, listViewOpen: 148.28, minListViewOpen: 133.49, maxListViewOpen: 162.99

@HardeepAsrani HardeepAsrani marked this pull request as draft July 23, 2024 19:31
@HardeepAsrani HardeepAsrani marked this pull request as ready for review July 25, 2024 04:05
@HardeepAsrani HardeepAsrani merged commit b0e3302 into development Jul 30, 2024
23 checks passed
@HardeepAsrani HardeepAsrani deleted the fix/issue-208 branch July 30, 2024 18:14
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants