-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment with formats in the toolbar #2255
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HardeepAsrani
added
the
pr-checklist-skip
Allow this Pull Request to skip checklist.
label
Jul 18, 2024
pirate-bot
added
the
pr-checklist-complete
The Pull Request checklist is complete. (automatic label)
label
Jul 18, 2024
Bundle Size Diff
|
Plugin build for 0350644 is ready 🛎️!
|
E2E TestsPlaywright Test Status: Performance ResultsserverResponse: 243.9, firstPaint: 138.6, domContentLoaded: 1561.1, loaded: 1562.15, firstContentfulPaint: 3500.35, firstBlock: 6777, type: 12.54, minType: 10.68, maxType: 15.75, typeContainer: 7.88, minTypeContainer: 6.73, maxTypeContainer: 9.97, focus: 29.32, minFocus: 25.94, maxFocus: 38.45, inserterOpen: 26.75, minInserterOpen: 21.14, maxInserterOpen: 50.34, inserterSearch: 0.7, minInserterSearch: 0.6, maxInserterSearch: 0.84, inserterHover: 3.88, minInserterHover: 3.22, maxInserterHover: 5.03, listViewOpen: 148.28, minListViewOpen: 133.49, maxListViewOpen: 162.99 |
Soare-Robert-Daniel
approved these changes
Jul 25, 2024
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Indicate that an issue has been resolved and released in a particular version of the product.
label
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-checklist-complete
The Pull Request checklist is complete. (automatic label)
pr-checklist-skip
Allow this Pull Request to skip checklist.
released
Indicate that an issue has been resolved and released in a particular version of the product.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Codeinwp/otter-internals/issues/208
Summary
This moves the Dynamic Link and Value from Format Dropdown to the main toolbar to improve visibility. It also changes the icon for Dynamic Link to avoid confusion.
Screenshots
Test instructions
Checklist before the final review