Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/product review line breaks #2173

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

preda-bogdan
Copy link
Contributor

Closes #2162.

Summary

Fixed multiline description for product review while maintaining sanitization.
Added e2e test to check for this specific case.

Screenshots

image

Test instructions

  1. Add a Product Review block
  2. In the Description of the product, add more lines of content
  3. Check the Product Review block on frontend multiline should be preserved

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Apr 10, 2024
@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 237.69 KB 237.69 KB 0 B (0.00%)
Blocks 1.5 MB 1.5 MB 0 B (0.00%)
CSS 91.76 KB 91.76 KB 0 B (0.00%)
Dashboard 200.11 KB 200.11 KB 0 B (0.00%)
Onboarding 152.76 KB 152.76 KB 0 B (0.00%)
Export Import 89.53 KB 89.53 KB 0 B (0.00%)
Pro 354.49 KB 354.49 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

Plugin build for 57a7d60 is ready 🛎️!

@preda-bogdan preda-bogdan linked an issue Apr 10, 2024 that may be closed by this pull request
@pirate-bot
Copy link
Contributor

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 222.25, firstPaint: 564.05, domContentLoaded: 1565.25, loaded: 1566, firstContentfulPaint: 3719.85, firstBlock: 5681.05, type: 12.66, minType: 10.75, maxType: 16.79, typeContainer: 9.17, minTypeContainer: 7.58, maxTypeContainer: 11.12, focus: 42.89, minFocus: 35.98, maxFocus: 53.61, inserterOpen: 29.13, minInserterOpen: 24.4, maxInserterOpen: 34.12, inserterSearch: 6.64, minInserterSearch: 6.12, maxInserterSearch: 7.07, inserterHover: 3.4, minInserterHover: 2.85, maxInserterHover: 4.3, listViewOpen: 158.86, minListViewOpen: 138.35, maxListViewOpen: 201.69

@vytisbulkevicius vytisbulkevicius merged commit 60690c0 into development Apr 10, 2024
12 checks passed
@vytisbulkevicius vytisbulkevicius deleted the fix/product_review_line_breaks branch April 10, 2024 12:08
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.6.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New lines break in Product Review block latest updates
4 participants