-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Heading typo component #1905
Conversation
Bundle Size Diff
|
Plugin build for c2143ff is ready 🛎️!
|
E2E SummaryTyping
Values above 60ms"0 - 135.85, 1 - 86.28, 2 - 89.34, 3 - 102.21, 4 - 110.84, 5 - 87.32, 6 - 95.98, 7 - 76.27, 8 - 81.38, 9 - 89.99, 10 - 99.56, 11 - 125.86, 12 - 85.32, 13 - 109.73, 14 - 88.94, 15 - 95.09, 16 - 91.87, 17 - 90.92, 18 - 91.90" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, for QA we should make sure that each control is tested with how it works with existing patterns.
@Soare-Robert-Daniel Tested and everything's fine regarding the PR, found a single issue that was also happening before, maybe we can fix it here:
|
@irinelenache, thanks for the catch. I think i missed updating that editor condition. Here is a little context on that thing. Before the new components, the heading used a slider in which after you crossed the value 3 it will use pixels as units -- on the idea that you do not need more than 3, which translates to 300%. Now with new components, we can choose the unit and not be limited by this. But, we still need to maintain backward compatibility, thus some conditions are creeping around. Here is a video 2023-10-05_14-16-52.mp4Notice how it behaves when you remove the |
@Soare-Robert-Daniel Tested again and everything's fine now 👍 |
🎉 This PR is included in version 2.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closes #1882
Summary
Moved the old typo component to the new one.
Development notes: It was not a smooth experience, but I was glad to find a new trick to tackle the responsive option.
Screenshots
Before
After
Test instructions
Switching to the PR build and checking if the options are the same as before and if they are working like before.
Checklist before the final review