-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extra files from build #1888
Conversation
Bundle Size Diff
|
Plugin build for 8d14c42 is ready 🛎️!
|
E2E SummaryTyping
Values above 60ms"0 - 64.32, 1 - 66.20, 2 - 102.26, 4 - 64.27, 5 - 75.16, 6 - 60.02, 7 - 74.17, 8 - 70.03, 9 - 80.40, 10 - 109.17, 11 - 82.04, 12 - 70.00, 13 - 77.80, 14 - 76.82, 15 - 81.39, 16 - 92.35, 17 - 86.37, 18 - 65.92" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Soare-Robert-Daniel This is fine too but can we try to see why this is happening in the first place and try to make sure the files aren't copied?
@Soare-Robert-Daniel Tested and everything's fine here 🚀 |
🎉 This PR is included in version 2.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closes #1876
Summary
wp-scripts
automatically gathers all.json
files and puts them inside each build.Reference: https://github.com/WordPress/gutenberg/blob/1fb1343c42a59d5062660a7da20a4bff4d06e369/packages/scripts/config/webpack.config.js#L263-L313
ℹ️ By using the already existing FIleManager in our setup, we can delete the extra file generated.
Screenshots
Output of
tree build -d
After change:
Before the change, the number was
471 directories
(you can see here the structure), now we have63 directories
Test instructions
Make sure that the build is valid since we deleted some extra files from the it.
Checklist before the final review